Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding lawn.sdf world to have sky and grassy ground plane for rovers #35

Merged
merged 5 commits into from
Apr 10, 2024
Merged

Adding lawn.sdf world to have sky and grassy ground plane for rovers #35

merged 5 commits into from
Apr 10, 2024

Conversation

slgrobotics
Copy link
Contributor

This is a modified default.sdf world file - I added sky, some lightning, grid and painted the ground plane grassy green.

I also added some friction/collision properties to the best of my knowledge.

I used "XML Copy Editor" to "pretty-print" the resulting SDF file - it fixes spaces and replaces single quotes with doubles.

image

@slgrobotics
Copy link
Contributor Author

@MaEtUgR - I granted you access to the repository, so that you could do whatever you want with it, if you choose so. Let me know if I can be of help.

improved second "sun" a bit
Copy link
Member

@Jaeyoung-Lim Jaeyoung-Lim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should not add the sky to the default world, since we want consistent behavior even for low-performance systems.

However, if you want to add the sky to a non-default world, please do so

@fredmarkus
Copy link
Collaborator

I agree. I think the default should be as simple as possible for the maximum machines to be able to run it. Plus the sky can be buggy when running on non-dedicated GPU machines (gazebosim/gz-sim#2267).

@slgrobotics
Copy link
Contributor Author

Ok, if it comes to catering to Celeron class machines with no graphics card - I understand... sad though, as people with standard 2020+ machines would see a dull skyless world by default. Bad marketing ;-)

Meanwhile I can rename this world to "lawn" and add it to the list of gz_worlds in gz_bridge/CMakeLists.txt

The way to see the sky would be "make px4_sitl gz_lawnmower_lawn"

Want to go this way? @Jaeyoung-Lim @frede791 - any other suggestions?

@fredmarkus
Copy link
Collaborator

@slgrobotics Yes I think that's good. Nothing to add from my side.

@Jaeyoung-Lim
Copy link
Member

@slgrobotics What would you actually test on the lawn mode? I would prefer the worlds we have actually have a use to test vehicle behaviors.

@slgrobotics
Copy link
Contributor Author

@Jaeyoung-Lim - well, when it comes for testing - all rovers will benefit from collision and friction properties in that ground plane. I test my lawnmower model with it all the time. But overall it just makes a better aesthetics for people who want it. Sky or no sky, current GZ default world isn't very appealing, even compared with the old "classic" one.

@slgrobotics slgrobotics changed the title Improved default.sdf world to have sky and grassy ground plane Adding lawn.sdf world to have sky and grassy ground plane for rovers Mar 28, 2024
@slgrobotics
Copy link
Contributor Author

I renamed my default.sdf to lawn.sdf to avoid conflicting with the legacy stuff. I also merged recent additions to default world into my lawn.sdf

@PerFrivik
Copy link
Contributor

Looks nice, would it be possible to have some more textures in the green plane? Sometimes I struggle to get a sense of speed when everything is the same color and without any features.

@slgrobotics
Copy link
Contributor Author

@PerFrivik - At the moment this PR is stale, there's no progress in code review and I'm not sure if it is ever going to be merged. I'd guess adding texture to the plane's visual is not a big deal, but I really don't want to do/disturb anything with it until we all have understanding of its future. As an option, we could have a separate PR on texture after this one is all done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants