-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sh3_arc* cleanup #109
sh3_arc* cleanup #109
Conversation
4999340
to
cad07df
Compare
include/SH3/arc/mft.hpp
Outdated
*/ | ||
|
||
/** Type check header */ | ||
struct Header |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I start using Uppercase for the first letter for structs from now on??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh that's just my personal style bleeding through. I'll fix it.
@z33ky Have you made the changes to this?? If so, I'll merge it :) |
Sorry, I've been distracted last weekend by a SBC I got and have been busy otherwise this week. |
There we go. I'll squash the fixup! after review and now only |
9d9d49f
to
ea10ac2
Compare
Looks really good, much cleaner than what we originally had. I'm curious though, how does this line Apart from that, squash when you're ready :) |
It's an rvalue-reference. Basically it's a reference where the caller promises that the value will not get used any further, which means you can "move" stuff out of it. |
ea10ac2
to
4746be9
Compare
There's also some minor additional refactoring, but generally this just moves some code around.
Also applies some minor phrasing changes.
This also shuffles the subarc file-loading functionality around, so some code moves from (formerly) sh3_arc to sh3::arc::subarc.
4746be9
to
7038cb1
Compare
Rebased onto master and squashed the fixup. There are two new commits on top for |
I decided the first step towards #95 is some cleanup in the arc* structs.
The rest should follow in the next days so I'd suggest you leave this PR unmerged until they are in. But you can start reviewing each commit (I'm gonna change each struct in a separate commit), hence me opening the PR already.