Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add biome change per player #10284

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yannicklamprecht
Copy link
Contributor

@yannicklamprecht yannicklamprecht commented Feb 24, 2024

resolves #9889

TODO:

  • Implement and call event
  • finish implementing BiomesSnapshot
  • add a handle to Chunk
  • test api with plugin
  • test compatibility with plugins using PlayerChunkLoadEvent
  • reduce diff
  • add paper comments

@Owen1212055
Copy link
Member

Owen1212055 commented Feb 24, 2024

We have a more generalized idea for something like this via our registry api, prolly better to wait.

Would allow us to make any registry modifiable.
Nvm, wrong thing.

@yannicklamprecht yannicklamprecht force-pushed the issue/9889-chunk-biome-packets branch 2 times, most recently from d5128d1 to 4548778 Compare February 25, 2024 23:30
@Machine-Maker
Copy link
Member

I'm thinking it would still be useful to get the biomes being sent by vanilla. Right now, the event is only dealing with any overrides. Implementing this might also be way nicer if this event was implemented on the server side. So the creation of BiomeSnapshots could be done in a lazy fashion to avoid creating snapshots for everything just to call the event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change biomes per-player in chunk/biome packets
3 participants