-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handled the validateDOMNesting error #1082
Conversation
This would fix the issue; however, at the moment, BottomCarousel is very much engineered to accept only text, a clear limitation of the component. Could you change the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see commentary above
@anth-volk I have updated the code, let me know if there's any correction to be made |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again, @dotslashbit. I left one comment that I should've flagged last time and neglected that is meant to keep the functioning of this prop standardized. After that, I think it's good to merge.
@@ -149,7 +149,7 @@ export default function HouseholdOutput(props) { | |||
<BottomCarousel | |||
selected={focus} | |||
options={HOUSEHOLD_OUTPUT_TREE[0].children} | |||
bottomText="PolicyEngine results may not constitute exact tax liabilities or benefit entitlements." | |||
bottomElements="PolicyEngine results may not constitute exact tax liabilities or benefit entitlements." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bottomElements="PolicyEngine results may not constitute exact tax liabilities or benefit entitlements." | |
bottomElements={<p>PolicyEngine results may not constitute exact tax liabilities or benefit entitlements.</p>} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies, should've also mentioned this before in the earlier review.
@anth-volk did the required changes, let me know if there's anything needed to be done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is perfect, thanks so much @dotslashbit!
Description
Please provide a summary of the changes and which issue is fixed. Please include relevant motivation and context.
closes #1065
Changes
There were nesting p elements, I have modified the structure of the elements to get the same output but now the outer element is a div
Screenshots
Before
After
Tests
Please describe how the change has been tested.