Hide program takeup parameters from web UI by setting economy: false #5639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These parameters don't have any effect in the web UI since takeup is assigned during microdata construction, not simulation time. Setting economy: false prevents confusion by hiding them from users. Fixes PolicyEngine#5638 🤖 Generated with Claude Code Co-Authored-By: Claude <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5639 +/- ##
=======================================
Coverage 99.07% 99.07%
=======================================
Files 2697 2697
Lines 39008 39008
Branches 171 171
=======================================
Hits 38647 38647
Misses 327 327
Partials 34 34 ☔ View full report in Codecov by Sentry. |
PavelMakarchuk
approved these changes
Feb 25, 2025
|
Good call, I added household: false too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These parameters don't have any effect in the web UI since takeup is assigned during microdata construction, not simulation time. Setting economy: false prevents confusion by hiding them from users.
Fixes #5638