Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Newsletter form improvement #9841

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Newsletter form improvement #9841

wants to merge 12 commits into from
+384 −113

Conversation

andyvan-ph
Copy link
Contributor

@andyvan-ph andyvan-ph commented Nov 11, 2024 •
edited
Loading

  • Adds newsletter signup to bottom of tutorials
  • Removes some annoying mid-page placements
  • Tweaks signup form to add some social proof / changes hog illustration to something more "engineer like"

Before
Screenshot 2024-11-13 at 09 22 35

After
Screenshot 2024-11-13 at 09 23 31

@vercel Vercel
Copy link

vercel bot commented Nov 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog ✅ Ready (Inspect) Visit Preview Nov 13, 2024 4:58pm

@andyvan-ph andyvan-ph changed the title WIPN: ewsletter form improvement WIP: ewsletter form improvement Nov 11, 2024
@andyvan-ph andyvan-ph changed the title WIP: ewsletter form improvement WIP: Newsletter form improvement Nov 11, 2024
Lior539
Lior539 reviewed Nov 13, 2024
View reviewed changes
src/components/NewsletterForm/index.tsx Outdated
Comment on lines 49 to 50
src="https://res.cloudinary.com/dmukukwp6/image/upload/posthog.com/src/images/swole-hog.png"
src="https://res.cloudinary.com/dmukukwp6/image/upload/engineer_47d6638eae.png"
objectFit="contain"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swole hog is more eye catching IMO. Music hog doesnt jump out really. Would keep swole hog

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

He is more eye-catching, but I do find swole hog's t-shirt hard to read; engineer hog is more visually polished but yes, muted.

Astronaut hog, call to adventure?

Screenshot 2024-11-13 at 9 58 52 AM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(sorry to bikeshed your PR Andy, the rearrangement is good!)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have an incoming alternative that works

src/components/NewsletterForm/index.tsx Outdated Show resolved Hide resolved
@andyvan-ph andyvan-ph changed the title WIP: Newsletter form improvement Newsletter form improvement Nov 13, 2024
ivanagas
ivanagas reviewed Nov 13, 2024
View reviewed changes
contents/tutorials/aa-testing.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove it from a bunch of product engineer/blog posts but add it to tutorials? I feel like it would be more relevant the other way around?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanagas ivanagas ivanagas left review comments

@Lior539 Lior539 Lior539 left review comments

@bijanbwb bijanbwb Awaiting requested review from bijanbwb

@daniloc daniloc Awaiting requested review from daniloc

@corywatilo corywatilo Awaiting requested review from corywatilo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andyvan-ph @daniloc @Lior539 @ivanagas