Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add config to disable Prefer: count=exact #2984

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

taimoorzaeem
Copy link
Collaborator

This should fix #2777.

@steve-chavez
Copy link
Member

@taimoorzaeem Oh, #2777 was labeled as idea. I've just added a description for it: still in need of discussion, do not implement. Sorry about that 😅. Generally I just open them to see if someone has any feedback.

So exposing count: exact is still a problem, however I'm not sure if disabling it is the correct solution.


The point of #2777 remains that it's still cumbersome to remove this value at the proxy level.

Since Prefer: tx=rollback can be disabled with a config maybe we can have a single config for all the preferences? I still need to think if this make sense but that would be better since we don't need to have one config for each preference.

Let's leave the PR open for now.

@steve-chavez
Copy link
Member

Since Prefer: tx=rollback can be disabled with a config maybe we can have a single config for all the preferences?

FYI, added this idea on #2987

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Config flag for disabling Prefer: count=exact
2 participants