Bugfix Update-ModuleManifest throws null pointer exception #1538

anamnavi · 2024-01-23T20:51:54Z

Enable Update-PSModuleManifest and Get-PSScriptFileInfo tests that got disabled along the way.
Fix bug where Update-PSModuleManifest throws null pointer, fixes #1487

Handle Update-PSModuleManifest calls with -Prerelease, -RequireLicenseAcceptance, and ExternalModuleDependencies parmaters on Windows PowerShell. Since Update-PSModuleManifest calls New-ModuleManifest but those parameters weren't supported for New-ModuleManifest on Windows PowerShell, we need to create the PrivateData entry with the parameter values and then replace the default PrivateData entry in the .psd1 with the correct/updated one.

Support cases where -PrivateData is a nested hashtable (this was a bug stemming from New-ModuleManifest and can't be fixed here but I've added bugfix so that Update-PSModuleManifest` can handle it on PSCore and WinPS.

PR Summary

PR Context

PR Checklist

…t being run

test/PSScriptFileInfoTests/GetPSScriptFileInfo.Tests.ps1

alerickson · 2024-01-24T21:35:30Z

test/UpdateModuleManifest/UpdateModuleManifest.Tests.ps1

@@ -86,7 +88,7 @@ Describe 'Test Update-PSModuleManifest' {
        }
    }

-    It "Update module manifest given Prerelease parameter" {
+    It "Update module manifest given Prerelease parameter" -Skip:$IsWindowsPowerShell {


Why is this not working on Windows PS?

the -Prerelease parameter was not included for New-ModuleManifest cmdlet in WindowsPowerShell per the docs

ExternalModuleDependencies and RequireLicenseAcceptance are the other paramaters also not included

Okay, considering we have to be backwards compatible with Windows PS 5.1 we should add error handling if someone on Windows PowerShell tries to use those parameters and specify that it's a feature only available on later versions of PS.

src/code/UpdateModuleManifest.cs

This reverts commit 83fbe9c.

src/code/UpdateModuleManifest.cs

Co-authored-by: Aditya Patwardhan <[email protected]>

…ble it up

alerickson

Just added one comment, but looks good otherwise

src/code/Utils.cs

src/code/UpdateModuleManifest.cs

…ell#1615) Add Name and Repository pipeline by property name (PowerShell#1451) Bugfix script parse whitespace (PowerShell#1457) Bug fix for Import-PSGetRepository in Windows PS (PowerShell#1460) Update README.md (PowerShell#1458) update chANGELOG, psd1, csproj for release 1.0.1 (PowerShell#1473) Bump System.Text.Json from 6.0.0 to 8.0.0 in /src/code (PowerShell#1475) Verify whether SourceLocation is a UNC path and select the appropriate ApiVersion (PowerShell#1479) TryConvertFromXml: Prevent NRE when NormalizedVersion is missing (PowerShell#1503) Update InstallHelper.cs (PowerShell#1510) Bump BenchmarkDotNet.Diagnostics.Windows in /test/perf/benchmarks (PowerShell#1528) enable isJFrogRepo flag for domains containing `artifactory` (PowerShell#1532) Fix 'name' bug with v2 JFrog Artifactory (PowerShell#1535) Bugfix Update-ModuleManifest throws null pointer exception (PowerShell#1538) Add tests for ADO v2 server (PowerShell#1539) Bugfix - Test if InstalledScriptInfos folder exists and create if needed (PowerShell#1542) * Test InstalledScriptInfos folder and create if needed * Update src/code/InstallHelper.cs Co-authored-by: Aditya Patwardhan <[email protected]> * Update src/code/InstallHelper.cs Co-authored-by: Aditya Patwardhan <[email protected]> --------- Co-authored-by: Aditya Patwardhan <[email protected]> Remove redeclaration of s_tempHome (PowerShell#1544) Bug fix for Update-PSResource not updating from correct repository (PowerShell#1549) Update changelog, version, releasenotes

Add verbose and debug messages for Container Registry Server (PowerShell#1615) Add Name and Repository pipeline by property name (PowerShell#1451) Bugfix script parse whitespace (PowerShell#1457) Bug fix for Import-PSGetRepository in Windows PS (PowerShell#1460) Update README.md (PowerShell#1458) update chANGELOG, psd1, csproj for release 1.0.1 (PowerShell#1473) Bump System.Text.Json from 6.0.0 to 8.0.0 in /src/code (PowerShell#1475) Verify whether SourceLocation is a UNC path and select the appropriate ApiVersion (PowerShell#1479) TryConvertFromXml: Prevent NRE when NormalizedVersion is missing (PowerShell#1503) Update InstallHelper.cs (PowerShell#1510) Bump BenchmarkDotNet.Diagnostics.Windows in /test/perf/benchmarks (PowerShell#1528) enable isJFrogRepo flag for domains containing `artifactory` (PowerShell#1532) Fix 'name' bug with v2 JFrog Artifactory (PowerShell#1535) Bugfix Update-ModuleManifest throws null pointer exception (PowerShell#1538) Add tests for ADO v2 server (PowerShell#1539) Bugfix - Test if InstalledScriptInfos folder exists and create if needed (PowerShell#1542) * Test InstalledScriptInfos folder and create if needed * Update src/code/InstallHelper.cs Co-authored-by: Aditya Patwardhan <[email protected]> * Update src/code/InstallHelper.cs Co-authored-by: Aditya Patwardhan <[email protected]> --------- Co-authored-by: Aditya Patwardhan <[email protected]> Remove redeclaration of s_tempHome (PowerShell#1544) Bug fix for Update-PSResource not updating from correct repository (PowerShell#1549) Update changelog, version, releasenotes

…ncies' in PSResourceInfo object (PowerShell#1604) Create OneBranch build and release pipeline (PowerShell#1605) Add verbose and debug messages for Container Registry Server (PowerShell#1615) Add Name and Repository pipeline by property name (PowerShell#1451) Bugfix script parse whitespace (PowerShell#1457) Bug fix for Import-PSGetRepository in Windows PS (PowerShell#1460) Update README.md (PowerShell#1458) update chANGELOG, psd1, csproj for release 1.0.1 (PowerShell#1473) Bump System.Text.Json from 6.0.0 to 8.0.0 in /src/code (PowerShell#1475) Verify whether SourceLocation is a UNC path and select the appropriate ApiVersion (PowerShell#1479) TryConvertFromXml: Prevent NRE when NormalizedVersion is missing (PowerShell#1503) Update InstallHelper.cs (PowerShell#1510) Bump BenchmarkDotNet.Diagnostics.Windows in /test/perf/benchmarks (PowerShell#1528) enable isJFrogRepo flag for domains containing `artifactory` (PowerShell#1532) Fix 'name' bug with v2 JFrog Artifactory (PowerShell#1535) Bugfix Update-ModuleManifest throws null pointer exception (PowerShell#1538) Add tests for ADO v2 server (PowerShell#1539) Bugfix - Test if InstalledScriptInfos folder exists and create if needed (PowerShell#1542) * Test InstalledScriptInfos folder and create if needed * Update src/code/InstallHelper.cs Co-authored-by: Aditya Patwardhan <[email protected]> * Update src/code/InstallHelper.cs Co-authored-by: Aditya Patwardhan <[email protected]> --------- Co-authored-by: Aditya Patwardhan <[email protected]> Remove redeclaration of s_tempHome (PowerShell#1544) Bug fix for Update-PSResource not updating from correct repository (PowerShell#1549) Update changelog, version, releasenotes

enable Update-ModuleManifest and Get-PSScriptFileInfo tests that aren…

fe9c356

…t being run

anamnavi changed the title ~~Enable Update-ModuleManifest and Get-PSScriptFileInfo tests that aren…~~ Bugfix Update-ModuleManifest throws null pointer exception Jan 23, 2024

anamnavi added 9 commits January 23, 2024 16:09

add CI tag for test

8f4fcc1

correctly add arguments for cmdlet invocation

f730399

add parameters for powershell cmd

e36d873

fix fullyQualifiedErrorId referenced in test

9c58531

only use RequireLicenseAcceptance switch parameter if it was present

30652e1

skip tests not for WinPS

10ecc5a

skip tests not for WinPS

b1b7276

code cleanup

4854d32

remove dummy test file

00acd7e

anamnavi requested review from alerickson and adityapatwardhan January 24, 2024 20:57

adityapatwardhan approved these changes Jan 24, 2024

View reviewed changes

alerickson reviewed Jan 24, 2024

View reviewed changes

anamnavi added 6 commits January 24, 2024 16:58

remove import build

e6de641

tmep changes to make it work

83fbe9c

Revert "tmep changes to make it work"

59350f9

This reverts commit 83fbe9c.

Update-ModuleManifest tests should work on WinPS

6848da8

add separte logic for WinPS

5f0fbe6

remove imports accidentally added

dad71bc

anamnavi requested a review from adityapatwardhan January 31, 2024 02:59

anamnavi added 4 commits January 30, 2024 22:00

remove typo

8e551eb

debug tests as it works fine locally

6bdafc0

set Uri differently as it wasn't being picked up

3e7bb66

code cleanup and adding more thorough comments

a20c8e5

anamnavi requested a review from alerickson January 31, 2024 05:53

adityapatwardhan requested changes Jan 31, 2024

View reviewed changes

anamnavi and others added 2 commits January 31, 2024 13:42

Update src/code/UpdateModuleManifest.cs

6a59288

Co-authored-by: Aditya Patwardhan <[email protected]>

Update src/code/UpdateModuleManifest.cs

190fbb9

Co-authored-by: Aditya Patwardhan <[email protected]>

anamnavi added 2 commits January 31, 2024 14:20

address code review feedback and make methods out ErrorRecord and bub…

2f10b87

…ble it up

use System.Environment.NewLine

bfef010

alerickson reviewed Jan 31, 2024

View reviewed changes

src/code/Utils.cs Outdated Show resolved Hide resolved

simplify method used to determine if we're running WinPS

efa98cd

anamnavi requested a review from adityapatwardhan January 31, 2024 20:34

adityapatwardhan requested changes Feb 1, 2024

View reviewed changes

src/code/UpdateModuleManifest.cs Outdated Show resolved Hide resolved

src/code/UpdateModuleManifest.cs Outdated Show resolved Hide resolved

address code review feedback and make return type of methods void

fd60f71

anamnavi requested a review from adityapatwardhan February 2, 2024 04:15

adityapatwardhan approved these changes Feb 2, 2024

View reviewed changes

alerickson approved these changes Feb 5, 2024

View reviewed changes

anamnavi merged commit 9738f15 into PowerShell:master Feb 5, 2024
10 checks passed

alerickson added Backport-1.0.x-approved and removed Backport-1.0.x-approved labels Feb 5, 2024

alerickson pushed a commit that referenced this pull request Feb 7, 2024

Bugfix Update-ModuleManifest throws null pointer exception (#1538)

5411107

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bugfix Update-ModuleManifest throws null pointer exception #1538

Bugfix Update-ModuleManifest throws null pointer exception #1538

anamnavi commented Jan 23, 2024 •

edited

Loading

alerickson Jan 24, 2024

anamnavi Jan 24, 2024

alerickson Jan 25, 2024

alerickson left a comment

Bugfix Update-ModuleManifest throws null pointer exception #1538

Bugfix Update-ModuleManifest throws null pointer exception #1538

Conversation

anamnavi commented Jan 23, 2024 • edited Loading

PR Summary

PR Context

PR Checklist

alerickson Jan 24, 2024

Choose a reason for hiding this comment

anamnavi Jan 24, 2024

Choose a reason for hiding this comment

alerickson Jan 25, 2024

Choose a reason for hiding this comment

alerickson left a comment

Choose a reason for hiding this comment

anamnavi commented Jan 23, 2024 •

edited

Loading