Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACR package name should be lowercase when creating ACR urls #1552

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

alerickson
Copy link
Member

PR Summary

ACR only accepts packages with lowercase names. When uploading blobs to ACR server, the package name should be lowercase (ie ACR will read the package name as being lowercase). The annotations (metadata) will keep the original casing of the package.

PR Context

PR Checklist

Copy link
Member

@adityapatwardhan adityapatwardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add a test for this. Can you open an issue to track this.

@alerickson alerickson merged commit 58d5940 into PowerShell:master Feb 8, 2024
10 checks passed
@alerickson alerickson deleted the acrPkgNameToLower branch February 8, 2024 20:26
alerickson added a commit to alerickson/PSResourceGet that referenced this pull request Apr 1, 2024
alerickson added a commit to alerickson/PSResourceGet that referenced this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants