fix: toolbar edge obscured by screen in landscape mode #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
感谢你的 PR 这个修改看上去非常棒，我会在CI通过后合并 |
|
测试有问题 |
|
iOS 上如果右侧没有挖孔，锁定和截图图标会一直保留在屏幕上 安卓应该也会有相同的问题，最好用 safeArea |
|
好的，那我们只能暂缓合并，我会在明天白天进行测试 具体是什么问题呢，这样我可以在测试时关注一下 |
|
这里原来是 safeArea safeArea 会让视频不居中，因为两边为缺口保留的区域宽度不同 |
|
只是对面板应用 safeArea，就像之前为底部小白条预留区域那样 |
|
好主意 |
ErBWs
suggested changes
Feb 19, 2025
| @@ -507,7 +507,7 @@ class _PlayerItemPanelState extends State<PlayerItemPanel> { | |||
| (Utils.isDesktop() || !videoPageController.isFullscreen) | |||
| ? Container() | |||
| : Positioned( | |||
| right: 0, | |||
| right: MediaQuery.of(context).padding.right, | |||
There was a problem hiding this comment.
Suggested change
| right: MediaQuery.of(context).padding.right, | |
| right: 0, |
参考下面自定义底部组件，在 SlideTransition 内用 SafeArea，保证侧边面板不会留在屏幕上
child: SlideTransition(
position: leftOffsetAnimation,
child: SafeArea(
top: false,
bottom: videoPageController.isFullscreen,
left: false,
right: videoPageController.isFullscreen,
child: Column(
Comment on lines
549
to
550
| left: MediaQuery.of(context).padding.left, | ||
| right: MediaQuery.of(context).padding.right, |
There was a problem hiding this comment.
同上，在 EmbeddedNativeControlArea 内部用 SafeArea
Comment on lines
704
to
705
| left: MediaQuery.of(context).padding.left, | ||
| right: MediaQuery.of(context).padding.right, |
There was a problem hiding this comment.
这里底下有现成的 SafeArea，直接修改 left 和 right 就可以
|
感谢建议，我之后去修复。 |
ErBWs
approved these changes
Feb 20, 2025
ErBWs
pushed a commit
to ErBWs/Kazumi
that referenced
this pull request
Feb 23, 2025
* fix: solve the display problem in landscape mode * fix: toolbar edge obscured by screen in landscape mode (cherry picked from commit 76945b3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Toolbar edge obscured by screen in landscape mode
before:
after: