Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix long file names #62

Closed
wants to merge 1 commit into from
Closed

Fix long file names #62

wants to merge 1 commit into from

Conversation

Kernald
Copy link
Collaborator

@Kernald Kernald commented Aug 3, 2021 •
edited
Loading

latexrun doesn't properly parse LaTeX's output when the filename doesn't fit in a single line - see aclements/latexrun#19. This forces it to use MAX_INT as a max line length, effectively leaving the line-wrapping job up to the terminal (which should be its responsibility, not LaTeX's), and works around this issue. 480 as a max line length, anything significantly longer seems to break something with //packages:glossaries-extra

Fixes #50

@Kernald
Copy link
Collaborator Author

Kernald commented Aug 3, 2021 •
edited
Loading

This surprisingly makes //packages:glossaries-extra_glossaries-extra_test flaky (it sometimes times out) - both on CI and locally. Maybe a smaller max line length (e.g. 200, something still significantly longer than the current 80) would be a good compromise?

Edit: after a bit of fiddling, 480 seems to be working fine and is hopefully long enough.

@Kernald Kernald force-pushed the fix-long-filenames branch from d9b9b05 to c614b54 Compare August 3, 2021 05:13
@Kernald
Copy link
Collaborator Author

Kernald commented Aug 3, 2021

Looks like 480, despite working >10 times locally, is still not working 100% of the time for this test. Not sure what's wrong...

@Kernald
Copy link
Collaborator Author

Kernald commented Aug 3, 2021

I actually just got the same issue with 80, so this is unlikely to be related - looks like there's an issue with this test.

@Kernald Kernald mentioned this pull request Aug 8, 2021
Merged
@Kernald
Fix long file names
702b957 
latexrun doesn't properly parse LaTeX's output when the filename doesn't
fit in a single line - see
aclements/latexrun#19. This forces it to use
480 as a max line length, effectively working around this issue.

Fixes ProdriveTechnologies#50
@Kernald Kernald force-pushed the fix-long-filenames branch from c614b54 to 702b957 Compare August 11, 2022 10:29
@Kernald
Copy link
Collaborator Author

Kernald commented Aug 11, 2022

@patbro Did you observe any issues with //packages:glossaries-extra in other PRs? This one seems to work fine locally, I vaguely remember seeing it fail with 80 as a max line length, I'm not too sure why the CI is sometimes timing out on //packages:glossaries-extra.

@patbro
Copy link
Member

patbro commented Sep 29, 2022

@patbro Did you observe any issues with //packages:glossaries-extra in other PRs? This one seems to work fine locally, I vaguely remember seeing it fail with 80 as a max line length, I'm not too sure why the CI is sometimes timing out on //packages:glossaries-extra.

I don't recall any issues with that package to be honest. But maybe my memory fills in the blanks here as well...

Maybe this is a Cirrus CI thing? Which might be solved when switching.

@Kernald
Copy link
Collaborator Author

Kernald commented Oct 10, 2022

This should probably be fixed by applying aclements/latexrun#52 instead.

@Kernald Kernald mentioned this pull request Oct 20, 2022
Merged
@Kernald
Copy link
Collaborator Author

Kernald commented Oct 20, 2022

Closing in favour of #98

@Kernald Kernald closed this Oct 20, 2022
@Kernald Kernald deleted the fix-long-filenames branch October 20, 2022 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing to build with long filenames
2 participants
@Kernald @patbro