Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug/issue 15 refactor DOM methods to correct base class implementation #139

Merged
merged 1 commit into from
Jan 11, 2024
Merged

bug/issue 15 refactor DOM methods to correct base class implementation #139

merged 1 commit into from
Jan 11, 2024

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Jan 10, 2024 •
edited
Loading

Related Issue

resolves #15

Summary of Changes

  1. Move attachShadow and innerHTML getter to Element base case, as per MDN

TODO

  1. Greenwood test case sanity check

@thescientist13 thescientist13 added the bug Something isn't working label Jan 10, 2024
@thescientist13 thescientist13 changed the title refactor DOM methods to correct base class implementation bug/issue 15 refactor DOM methods to correct base class implementation Jan 10, 2024
@thescientist13 thescientist13 merged commit ba8baf0 into master Jan 11, 2024
12 checks passed
@thescientist13 thescientist13 deleted the bug/issue-15-refactor-innerHTML-setter branch January 11, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTMLTemplateElement should not have a set innerHTML method
1 participant
@thescientist13