Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/issue 142 adopt ESM and bundler friendly fork of acorn-jsx #143

Merged
merged 4 commits into from
Mar 9, 2024
Merged

feature/issue 142 adopt ESM and bundler friendly fork of acorn-jsx #143

merged 4 commits into from
Mar 9, 2024

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Feb 10, 2024 •
edited
Loading

Related Issue

resolves #142

Will break because acorn-jsx needs type="module" and patch-package does not track package.json change, so it will have to be done manually for testing locally

Summary of Changes

  1. Vendor an ESM fork of acorn-jsx

TODO

  1. Fork and install
  2. How to actually reproduce in rollup.config.js
  3. test in Greenwood - feature/issue 1197 Lit v3 upgrade and SSR fixes and enhancements greenwood#1201

@thescientist13 thescientist13 changed the title feature/issue 142 ESM acorn-jsx feature/issue 142 vendor ESM acorn-jsx fork Feb 10, 2024
@thescientist13 thescientist13 added the feature New feature or request label Feb 10, 2024
@thescientist13 thescientist13 self-assigned this Feb 10, 2024
@netlify Netlify
Copy link

netlify bot commented Feb 10, 2024 •
edited
Loading

❌ Deploy Preview for merry-caramel-524e61 failed.

Name Link
🔨 Latest commit 02b1930
🔍 Latest deploy log https://app.netlify.com/sites/merry-caramel-524e61/deploys/65c80f6ad0c19a00070ec5e4

@thescientist13 thescientist13 marked this pull request as ready for review February 11, 2024 01:47
@thescientist13 thescientist13 mentioned this pull request Feb 27, 2024
Merged
16 tasks
@thescientist13 thescientist13 force-pushed the feature/issue-142-acorn-jsx-esm branch from 7290ee6 to a5f0f47 Compare March 9, 2024 19:11
@thescientist13 thescientist13 changed the title feature/issue 142 vendor ESM acorn-jsx fork feature/issue 142 adopt ESM and bundler friendly fork of acorn-jsx Mar 9, 2024
@thescientist13 thescientist13 merged commit 0fbaf14 into master Mar 9, 2024
12 checks passed
@thescientist13 thescientist13 deleted the feature/issue-142-acorn-jsx-esm branch March 9, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thescientist13 thescientist13

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

adopt a bundle friendly and ESM compatible version of acorn-jsx
1 participant
@thescientist13