Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/issue 154 light DOM children aka HTML web components #155

Merged
merged 10 commits into from
Oct 19, 2024
Merged

feature/issue 154 light DOM children aka HTML web components #155

merged 10 commits into from
Oct 19, 2024

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Apr 10, 2024 •
edited
Loading

Related Issue

resolves #154

Summary of Changes

  1. Support preservation of nested Light DOM content (HTML Web Components) and add test cases
  2. Document HTML Web Components example

TODO

  1. create a sandbox version / validate for standards compliance (this is allowed, right? 😅 )
  2. basic test case
  3. downstream testing
  4. Clean up console log / debugging

Additional use cases to validate?

  1. Needs to be recursive
  2. Needs to handle duplicate content - why?
  3. Needs to handle self closing tags
  4. handle all node types - not sure what else to support...

@thescientist13 thescientist13 added question Further information is requested enhancement Improvement to existing functionality labels Apr 10, 2024
@thescientist13 thescientist13 self-assigned this Apr 10, 2024
@thescientist13 thescientist13 force-pushed the enhancement/issue-154-light-dom-slots-aka-html-web-components branch from a7f537f to 027034c Compare September 28, 2024 00:07
This was referenced Sep 28, 2024
Merged
Closed
@thescientist13 thescientist13 marked this pull request as ready for review September 28, 2024 01:05
@thescientist13 thescientist13 added feature New feature or request and removed enhancement Improvement to existing functionality labels Sep 28, 2024
@thescientist13 thescientist13 changed the title enhancement/issue 154 light DOM children aka HTML web components feature/issue 154 light DOM children aka HTML web components Sep 28, 2024
@thescientist13 thescientist13 force-pushed the enhancement/issue-154-light-dom-slots-aka-html-web-components branch from 6777786 to ecbe3b4 Compare October 18, 2024 21:38
@thescientist13 thescientist13 removed the question Further information is requested label Oct 19, 2024
@thescientist13 thescientist13 added documentation Improvements or additions to documentation and removed 0.15.0 labels Oct 19, 2024
@thescientist13 thescientist13 merged commit cb4ae5c into master Oct 19, 2024
12 checks passed
@thescientist13 thescientist13 deleted the enhancement/issue-154-light-dom-slots-aka-html-web-components branch October 19, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thescientist13 thescientist13

Labels
documentation Improvements or additions to documentation feature New feature or request
Projects
No open projects
[Greenwood] Phase 9 - Standards and Conventions
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Light DOM children / slots (aka HTML Web Components)
1 participant
@thescientist13