Skip to content

Commit

Permalink
No commit message
Browse files Browse the repository at this point in the history
  • Loading branch information
Jeffrey Holmes committed Jul 15, 2008
1 parent e8ca7fa commit 1ea97cc
Show file tree
Hide file tree
Showing 4 changed files with 27 additions and 27 deletions.
46 changes: 24 additions & 22 deletions DEVELOPMENT_LOG.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,26 +3,28 @@ Notes about pyORBIT Development

title 01.31.2008 py::orbit::lattice modification
The initial state is a revision 59.
Problems with AccLattice and AccElement classes:
1. We need possibility to access the particular node by using
name (lattice could have duplicates!) or position. The position
of the element cannot be a property of the node, because the same
node could be a part of other lattice or sub-lattice. So, it should be
the method of the lattice class - getPosition(index).
The position means the start point only. All other information should be
retrieved from node (AccElement class instance).

2. To provide the ability to track particles from one particular node
to another we can use sub-lattices instead of very complicated
start-stop methods in nodes and action containers. So, the "should stop"
methods can be removed from AccActionsContainer class. The new method for
sub-lattice generation should be introduced.

3. Initialization structure for nodes is not necessary. We need initialization
only for the lattice (to put positions into an array). The node
initialization should be moved to TEAPOT base element as a part of
construction of nodes.
Problems with AccLattice and AccElement classes:

4. AccActionsContainer has sets of similar methods for entrance, body, and exit
actions. It could be a shorter and clearer code if we provide one set
of methods with a parameter specifying ENTRANCE,BODY, and EXIT.
1. We need possibility to access any particular node by using its
name (lattice could have duplicates!) or position. The position
of the element cannot be a property of the node, because the same
node could be a part of more than one lattice or sub-lattice. Thus,
it should be a method of the lattice class - getPosition(index).
The position means the start point of the node. All other information
should be retrieved from node (AccElement class instance).

2. To provide the ability to track particles from one particular node
to another we can use sub-lattices instead of very complicated
start-stop methods in nodes and action containers. So, the
"should stop" methods can be removed from AccActionsContainer class.
The new method for sub-lattice generation should be introduced.

3. Initialization structure for nodes is not necessary. We need initialization
only for the lattice (to put positions into an array). The node
initialization should be moved to TEAPOT base element as a part of
construction of nodes.

4. AccActionsContainer has sets of similar methods for entrance, body, and
exit actions. It could be a shorter and clearer code if we provide
one set of methods with a parameter specifying ENTRANCE, BODY,
or EXIT.
6 changes: 3 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ DIRS += ./ext

all: compile

compile:
compile:
@for dir in $(DIRS); do \
(cd $$dir; if [ -f ./Makefile ]; then $(MAKE) compile; fi;); \
done
Expand All @@ -17,6 +17,6 @@ clean:
done
rm -rf ./bin/pyORBIT
rm -rf ./doc/html
docs:

docs:
doxygen
1 change: 0 additions & 1 deletion READ_ME
Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,3 @@ PYTHONPATH - should be modified to include access to the ORBIT
export PYTHONPATH=${PYTHONPATH}:${ORBIT_ROOT}/py:${ORBIT_ROOT}/modules

ORBIT_ARCH - architecture of the system. At present it is LINUX only.

1 change: 0 additions & 1 deletion config
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
source ${ORBIT_ROOT}/modules/config
source ${ORBIT_ROOT}/py/config

0 comments on commit 1ea97cc

Please sign in to comment.