Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added load_more to accumulate multiple configs #42

Merged
merged 1 commit into from
Aug 28, 2023
Merged

feat: added load_more to accumulate multiple configs #42

merged 1 commit into from
Aug 28, 2023

Conversation

Swivelgames
Copy link
Contributor

@Swivelgames Swivelgames commented Aug 26, 2023 •
edited
Loading

Fixes #41

  • Change is NON-BREAKING
  • Adds load_and_append()
    • Full test coverage
    • Coherent docs
  • Adds load_and_append_async()
    • Full test coverage
    • Coherent docs
  • Adds read_and_append()
    • Full test coverage
    • Coherent docs

@Swivelgames Swivelgames changed the title feat: added load_more to accumulate multiple inis feat: added load_more to accumulate multiple configs Aug 26, 2023
QEDK
QEDK requested changes Aug 27, 2023
View reviewed changes
Copy link
Owner

@QEDK QEDK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me! Some minor changes.

src/ini.rs Outdated Show resolved Hide resolved
src/ini.rs Outdated Show resolved Hide resolved
tests/test.rs Outdated Show resolved Hide resolved
tests/test.rs Outdated Show resolved Hide resolved
@QEDK QEDK added the enhancement New feature or request label Aug 27, 2023
@Swivelgames
Copy link
Contributor Author

@QEDK Renamed load_more() to load_and_append() (along with sync). Also added a read_and_append!

See changes here

@Swivelgames Swivelgames requested a review from QEDK August 28, 2023 07:13
QEDK
QEDK approved these changes Aug 28, 2023
View reviewed changes
Copy link
Owner

@QEDK QEDK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

@QEDK QEDK merged commit e1418c6 into QEDK:master Aug 28, 2023
3 checks passed
@Swivelgames Swivelgames deleted the load-more branch August 29, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QEDK QEDK QEDK approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for load()ing multiple files
2 participants
@Swivelgames @QEDK