Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Allow more powerful config file #2

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

MrKevinWeiss
Copy link

@MrKevinWeiss MrKevinWeiss commented May 2, 2023

TBD:

  • Benchmarks
    • _attempted_value scaling
    • import scaling
    • invoke python
    • setting value with python vs select
  • Tests
    • Set each value type/read
    • importing dirs
    • Error conditions

@MrKevinWeiss
Copy link
Author

Benchmarks show that the python config file using eval go pretty slow.

Running some quick local tests that only use simple features such as if, else, and source I get:

Execution time for the regex version (1000 runs): 0.037437569997564424 seconds
Execution time for the ast version (1000 runs): 0.22356338799727382 seconds

If we really care about speed we would cripple the config language quite a bit to use just the regex (which is currently what is being used to parse). This would mean we need some limitations...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant