Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address deprecated wasm-bindgen init api #13

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

noname0310
Copy link
Contributor

This is the signature of the __wbg_init generated when using the latest version of wasm-bindgen.

/**
* If `module_or_path` is {RequestInfo} or {URL}, makes a request and
* for everything else, calls `WebAssembly.instantiate` directly.
*
* @param {{ module_or_path: InitInput | Promise<InitInput>, memory?: WebAssembly.Memory, thread_stack_size?: number }} module_or_path - Passing `InitInput` directly is deprecated.
* @param {WebAssembly.Memory} memory - Deprecated.
*
* @returns {Promise<InitOutput>}
*/
export default function __wbg_init (module_or_path?: { module_or_path: InitInput | Promise<InitInput>, memory?: WebAssembly.Memory, thread_stack_size?: number } | InitInput | Promise<InitInput>, memory?: WebAssembly.Memory): Promise<InitOutput>;

We're currently using a deprecated api in our worker.js file. This causes the following warning to appear in the console when using the library
image

This PR fixes this issue by addressing the deprecated api

noname0310 added a commit to noname0310/babylon-mmd that referenced this pull request Sep 26, 2024
@RReverser
Copy link
Owner

The CI is failing, this will need to wait for #12 to be merged first.

@RReverser RReverser merged commit 1c8c7e5 into RReverser:main Oct 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants