Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto podcaster #4016

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Auto podcaster #4016

wants to merge 9 commits into from

Conversation

boyska
Copy link

@boyska boyska commented Mar 16, 2024

convert a feed to a podcast (ie: add <enclosure>) based on simple heuristics.

Copy link

github-actions bot commented Mar 16, 2024

Pull request artifacts

Bridge Context Status
AutoPodcaster 1 url (pr) ⚠️ The feed has no items

last change: Tuesday 2024-06-18 20:16:24

@dvikan
Copy link
Contributor

dvikan commented Mar 31, 2024

in essence this puts media urls into the enclosures property.

you still working on this?

@boyska
Copy link
Author

boyska commented Apr 19, 2024

in essence this puts media urls into the enclosures property.

yes

you still working on this?

I have it running on production, so yes.
However, I don't want to bother you with a review until I bring it to a better level of quality.
But of course, if you want to do an early review of this and give me some feedback of what I should improve, that's more than welcome!

@boyska boyska marked this pull request as ready for review April 23, 2024 22:04
@dvikan
Copy link
Contributor

dvikan commented Jun 18, 2024

i pushed a commit. might have introduced a bug by dropping array_values.

@boyska
Copy link
Author

boyska commented Jun 18, 2024

i pushed a commit. might have introduced a bug by dropping array_values.

hey thanks, much appreciated.

This leads me to wondering if what this PR really misses is some testing. WDYT?

And also: what "style" of unit testing would you prefer? narrower unit testing, or broader integration tests (which would require files to be uploaded somewhere)? The latter would be able to discover changes in archive.org output, but involves external resources in the testing chain, which is usually not appreciated.

@dvikan
Copy link
Contributor

dvikan commented Jun 18, 2024

i think current pr is good enough. i can see the value in extracting media from feed content and putting them into enclosure.

it's not a proper podcast/itunes format though. maybe we can improve that later.

@boyska
Copy link
Author

boyska commented Aug 2, 2024

it's not a proper podcast/itunes format though. maybe we can improve that later.

what do you mean? what's missing to be a proper podcast/itunes?
I will be happy to improve this if you have any suggestion, even after this gets merged in master.

@dvikan
Copy link
Contributor

dvikan commented Aug 3, 2024

this bridge simply adds audios to enclosures. podcast/itunes is much more than that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants