Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Adds CEL rule to DRClusterConfig fields #1819

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

raaizik
Copy link
Contributor

@raaizik raaizik commented Feb 9, 2025

ClusterID is required field that's also immutable
Resolves #1802

@raaizik raaizik changed the title Adds CEL rule for clusterID [WIP] Adds CEL rule for clusterID Feb 9, 2025
@raaizik raaizik changed the title [WIP] Adds CEL rule for clusterID [WIP] Adds CEL rule to DRClusterConfig fields Feb 9, 2025
@rakeshgm
Copy link
Member

rakeshgm commented Feb 10, 2025

CEL validation testing could be add here as well. it would be great if you can add the tests but besides that the changes looks okay for me. https://github.com/RamenDR/ramen/tree/main/internal/controller/cel

ClusterID is required field that's also immutable

Signed-off-by: raaizik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants