-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert #67
Conversation
Intent Cross-Validation Results (3 folds)
Entity Cross-Validation Results (5 folds)
|
wdyt @akelad & @melindaloubser1 ? Not sure if we should merge this, maybe just in a branch for eval from the CDD hackathon? Including both convert & spacy in this starter pack seems a bit heavy. ( have taken spaCy out in this PR for the purpose of testing) |
Ja I think originally we removed convert because of the heaviness - On the other hand, maybe it's good if one starter pack uses it. |
what were the original results like? we def need spacy in :D |
see here: #71 (comment) so weighted average intent f1 goes from 0.86 to 0.96 (!) entities not really affected |
put spacy back so we can see how long eval takes. Isn't it also a thing that windows users can't use convert right now because of |
Intent Cross-Validation Results (3 folds)
Entity Cross-Validation Results (5 folds)
|
Looks like it's a matter of ~4 min vs ~5 min; the only reason I'd say not to do this is if it prevents windows users from using the starterpack as is (tensorflow-text requirement) |
I think when we switch to tf2.3 that won't be a problem anymore? but not sure |
yeah let's wait until this is compatible for windows users as well |
closing since Convert is no longer a publicly available model |
No description provided.