Merge pull request #109 from Razzmatazzz/lang-change-notify

Notify the user an app restart may be required on changing language.
Razzmatazzz · Aug 17, 2023 · 9aa1c1e · 9aa1c1e
2 parents 78f34bb + 9531eec
commit 9aa1c1e
Show file tree

Hide file tree

Showing 4 changed files with 33 additions and 1 deletion.
diff --git a/RemnantSaveGuardian/Views/Pages/SettingsPage.xaml b/RemnantSaveGuardian/Views/Pages/SettingsPage.xaml
@@ -113,7 +113,7 @@
             <TextBlock Name="lblMissingItemColor" Text="{lex:Loc}" ToolTip="{lex:Loc}" VerticalAlignment="Center" Margin="20,0,0,0"/>
         </WrapPanel>
         <WrapPanel Margin="0,2,0,0">
-            <ComboBox Name="cmbSwitchLanguage" VerticalAlignment="Center" Width="Auto" SelectionChanged="cmbSwitchLanguage_SelectionChanged"/>
+            <ComboBox Name="cmbSwitchLanguage" VerticalAlignment="Center" Width="Auto"/>
             <TextBlock Name="lblSwitchLanguage" Text="{lex:Loc}" ToolTip="{lex:Loc}" VerticalAlignment="Center" Margin="20,0,0,0"/>
         </WrapPanel>
         <WrapPanel Margin="0,2,0,0">

diff --git a/RemnantSaveGuardian/Views/Pages/SettingsPage.xaml.cs b/RemnantSaveGuardian/Views/Pages/SettingsPage.xaml.cs
@@ -66,6 +66,7 @@ public SettingsPage(ViewModels.SettingsViewModel viewModel)
                     else
                         cmbSwitchLanguage.SelectedItem = culture.NativeName;
                 }
+                cmbSwitchLanguage.SelectionChanged += cmbSwitchLanguage_SelectionChanged;
 
                 radThemeLight.IsChecked = Properties.Settings.Default.Theme == "Light";
 
@@ -314,6 +315,7 @@ private void cmbSwitchLanguage_SelectionChanged(object sender, SelectionChangedE
                 WPFLocalizeExtension.Engine.LocalizeDictionary.Instance.Culture = culture;
                 Application.Current.MainWindow.Language = System.Windows.Markup.XmlLanguage.GetLanguage(culture.IetfLanguageTag);
                 Properties.Settings.Default.Language = langs[cmbSwitchLanguage.SelectedIndex].Name;
+                Logger.Success(Loc.T("Language_change_notice_{chosenLanguage}", new() { { "chosenLanguage", culture.DisplayName } }));
             }
         }
     }

diff --git a/RemnantSaveGuardian/locales/Strings.Designer.cs b/RemnantSaveGuardian/locales/Strings.Designer.cs
diff --git a/RemnantSaveGuardian/locales/Strings.resx b/RemnantSaveGuardian/locales/Strings.resx
@@ -435,4 +435,7 @@
   <data name="lblSwitchLanguage_Text" xml:space="preserve">
     <value>Select language</value>
   </data>
+  <data name="Language_change_notice_{chosenLanguage}" xml:space="preserve">
+    <value>Language changed to {chosenLanguage}. You may have to restart to app for the change to fully apply.</value>
+  </data>
 </root>