-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suppress unnecessary warnings #245
Suppress unnecessary warnings #245
Conversation
ba1b664
to
8594ca4
Compare
This seems to be working -- package warnings are not shown anymore. The unit tests are failing due to the known adjoint sensitivity problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Aggressive solution I like it
8594ca4
to
d424a6d
Compare
Using |
d424a6d
to
26f21fe
Compare
a5215bb
to
d5ae0be
Compare
I think this should work. There are multiple locations I need to add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good. The warnings that are still in the log are ones we can fix if we take the time to go through them one-by-one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good!
Attempting to disable this warning to show up as RMG-Py users freak out when seeing Julia error message.