Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update kafka documentation #113

Merged
merged 4 commits into from
Sep 28, 2024
Merged

Conversation

RongDu7
Copy link
Contributor

@RongDu7 RongDu7 commented Sep 14, 2024

Please check the following - and then delete this message:

  • If you are creating a new page, does it contain the following value at the top, with x being the position in the folder?
---
sidebar_position: x
---
  • If you are creating a new sub-folder, does it have a _category_.json file with the appropriate descriptive information?
  • Are all your images / videos named appropriately and in the correct location ("image1.png" e.g. will not be accepted)
  • Are all your code blocks properly closed off?
  • Does your file have an appropriate and descriptive file name, and main header?

Failure to include these will result in your request not being reviewed.

@RongDu7 RongDu7 requested review from SassafrasAU and a team as code owners September 14, 2024 03:38
Copy link
Contributor

@SassafrasAU SassafrasAU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the most part, one minor change though, could you please move all headings up one, so your title becomes # Crowd Monitoring & Player Tracking Project Plan: Apache Kafka , and then following headings start from ##

Thanks :)

@SassafrasAU SassafrasAU merged commit 68119a1 into Redback-Operations:main Sep 28, 2024
1 check failed
SassafrasAU added a commit that referenced this pull request Sep 28, 2024
SassafrasAU added a commit that referenced this pull request Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants