Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed evo floating text bug #1185

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fixed evo floating text bug #1185

wants to merge 1 commit into from

Conversation

Jayefuu
Copy link
Collaborator

@Jayefuu Jayefuu commented Feb 26, 2021

We managed to get into a state where the evo never quite reached 1 because the code to set the evolution was inside the if statement. Therefore +0% evo would pop up for the whole of late game

grilledham
grilledham requested changes Mar 7, 2021
View reviewed changes
Copy link
Collaborator

@grilledham grilledham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We did discuss this on discord, but I'll put it here incase you have forgotten.

You probably want to check round(extra*100,2) >= 0.01 instead. Consider what would happen if evolution was 0.5 but extra was 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grilledham grilledham grilledham requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jayefuu @grilledham