Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added in World Size parameter to World Editor #5960

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

HyperbolicHadron
Copy link
Contributor

@HyperbolicHadron HyperbolicHadron commented Feb 25, 2025

Brief Description of What This PR Does

Adds in a World Size parameter to the Planet Editor.

Related Issues

Part of a roadmap item (https://wiki.revolutionarygamesstudio.com/wiki/Release_Roadmap#0.8.x_(world_and_auto-evo_updates))

Reduces problem #3563

Progress Checklist

Note: before starting this checklist the PR should be marked as non-draft.

  • PR author has checked that this PR works as intended and doesn't
    break existing features:
    https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
    (this is important as to not waste the time of Thrive team
    members reviewing this PR)
  • Initial code review passed (this and further items should not be checked by the PR author)
  • Functionality is confirmed working by another person (see above checklist link)
  • Final code review is passed and code conforms to the
    styleguide.

Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.

@HyperbolicHadron HyperbolicHadron marked this pull request as draft February 25, 2025 15:38
@HyperbolicHadron
Copy link
Contributor Author

This should be basically done, just waiting on #5961 to be merged first. Or if I need to do something different with the localization files so that merging doesn't break anything.

@hhyyrylainen hhyyrylainen added this to the Release 0.8.2 milestone Feb 26, 2025
@hhyyrylainen
Copy link
Member

The other PR is now merged.

@HyperbolicHadron HyperbolicHadron force-pushed the world_size_editor_parameter branch from 85055b1 to b566905 Compare February 27, 2025 16:17
@HyperbolicHadron HyperbolicHadron marked this pull request as ready for review February 27, 2025 16:49
@HyperbolicHadron
Copy link
Contributor Author

HyperbolicHadron commented Feb 27, 2025

I changed the enum comment as requested, and I finished testing so everything seems good now. (#5961 did fix the issue with larger world sizes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

2 participants