Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to stop rieMiner when a tuple is found in Search mode #30

Merged
merged 2 commits into from
Mar 1, 2023

Conversation

MakisChristou
Copy link
Contributor

No description provided.

@Pttn
Copy link
Member

Pttn commented Feb 28, 2023

Your code stops the search when primeCount > _parameters.tupleLengthMin, but tupleLengthMin can be set by the TupleLengthMin option, so it might stop before finding a constellation of desired length. For example, if I am looking for 8-tuples, but want to see 6-tuples and set TupleLengthMin = 6, the search will stop as soon as a 7-tuple is found.
You can use the length of the Vector storing the Pattern instead.

KeepRunning should be documented in the ReadMe.

Nitpicking:

  • Since _options.keepRunning is a Bool, it would be a bit nicer to assign true/false rather than 1/0.
  • Put keepRunning(0) after port(28332) (or declare keepRunning after apiPort) so the Initializer List Order is the same as the Member Declarations'. Otherwise, the compiler may warn "... will be initialized after ... when initialized here".

@MakisChristou MakisChristou force-pushed the master branch 2 times, most recently from b9e0e39 to cd04719 Compare March 1, 2023 07:20
@MakisChristou
Copy link
Contributor Author

Thanks for the feedback. Better now?

@Pttn
Copy link
Member

Pttn commented Mar 1, 2023

Looks good now, thank you for the contribution!

@Pttn Pttn merged commit 77a45b5 into RiecoinTeam:master Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants