feat: New tooltips and color behavior for private apps bar #33243

MartinSchoeler · 2024-09-10T18:41:36Z

Proposed changes (including videos or screenshots)

Issue(s)

Further comments

Currently I don't think you can test this without changing the values in code directly, due an issue that is causing the apps listing endpoints to always return -1, this can be merged without fixing the endpoint issue, since we are only checking for the values, when the endpoint is fixed this will work fine

changeset-bot · 2024-09-10T18:41:40Z

🦋 Changeset detected

Latest commit: 08b93d5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages

Name	Type
@rocket.chat/meteor	Major
@rocket.chat/i18n	Major
@rocket.chat/mock-providers	Patch
@rocket.chat/ui-contexts	Major
@rocket.chat/web-ui-registration	Major
@rocket.chat/fuselage-ui-kit	Major
@rocket.chat/ui-client	Major
@rocket.chat/uikit-playground	Patch
@rocket.chat/gazzodown	Major
@rocket.chat/livechat	Patch
@rocket.chat/ui-avatar	Major
@rocket.chat/ui-video-conf	Major
@rocket.chat/core-typings	Major
@rocket.chat/rest-typings	Major
@rocket.chat/api-client	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/models	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

dionisio-bot · 2024-09-10T18:41:47Z

Looks like this PR is not ready to merge, because of the following issues:

This PR is missing the 'stat: QA assured' label
This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

codecov · 2024-09-10T18:52:19Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.91%. Comparing base (abe1570) to head (61a4e98).

Additional details and impacted files

@@              Coverage Diff               @@
##           release-7.0.0   #33243   +/-   ##
==============================================
  Coverage          76.91%   76.91%           
==============================================
  Files                378      378           
  Lines              19035    19035           
  Branches            4905     4905           
==============================================
  Hits               14640    14640           
  Misses              4168     4168           
  Partials             227      227

Flag	Coverage Δ
unit	`76.91% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

github-actions · 2024-09-16T12:29:02Z

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33243/
on branch `gh-pages` at 2024-09-18 16:51 UTC

* feat: New tooltips and behavior for private apps bar * Create brown-pants-press.md

* feat: New empty state for upgrading private Apps * chore: Change Marketplace info modal text (#33239) * feat: New tooltips and color behavior for private apps bar (#33243) * feat: New tooltips and behavior for private apps bar * Create brown-pants-press.md * feat: new modal on Private Apps install (#33275) * feat: new modal on Private Apps install * add more variations * Create eleven-rockets-hug.md * chore: change grandfathered modal text (#33291) * chore: Use apps provider to check maxPrivateApps * fix: adds minor fixes to UI and changes requested on review * Update changeset * Replace negative boolean * Refactor `AppsUsageCard` * Add unit test for `AppsUsageCard` * Add unit test for `PrivateEmptyState` * Add unit test for `EnabledAppsCount` * Move tooltip logic away from `useAppsCountQuery` --------- Co-authored-by: Lucas Pelegrino <[email protected]> Co-authored-by: Tasso <[email protected]>

MartinSchoeler added this to the 6.13 milestone Sep 10, 2024

MartinSchoeler added 2 commits September 16, 2024 09:23

feat: New tooltips and behavior for private apps bar

802d1f7

Create brown-pants-press.md

9cd3726

MartinSchoeler force-pushed the private-apps-gauge branch from f508f4d to 9cd3726 Compare September 16, 2024 12:23

MartinSchoeler changed the base branch from develop to release-7.0.0 September 16, 2024 12:23

MartinSchoeler modified the milestones: 6.13, 7.0 Sep 16, 2024

Merge branch 'release-7.0.0' into private-apps-gauge

61a4e98

MartinSchoeler marked this pull request as ready for review September 17, 2024 16:37

MartinSchoeler requested a review from a team as a code owner September 17, 2024 16:37

MartinSchoeler changed the title ~~feat: New tooltips and behavior for private apps bar~~ feat: New tooltips and color behavior for private apps bar Sep 17, 2024

MartinSchoeler removed this from the 7.0 milestone Sep 18, 2024

MartinSchoeler changed the base branch from release-7.0.0 to unsuported-marketplace September 18, 2024 16:45

Merge branch 'unsuported-marketplace' into private-apps-gauge

08b93d5

MartinSchoeler merged commit 755b453 into unsuported-marketplace Sep 18, 2024
6 of 7 checks passed

MartinSchoeler deleted the private-apps-gauge branch September 18, 2024 16:46

MartinSchoeler added a commit that referenced this pull request Sep 18, 2024

feat: New tooltips and color behavior for private apps bar (#33243)

bbcec1c

* feat: New tooltips and behavior for private apps bar * Create brown-pants-press.md

MartinSchoeler added a commit that referenced this pull request Sep 18, 2024

feat: New tooltips and color behavior for private apps bar (#33243)

8d83b1f

* feat: New tooltips and behavior for private apps bar * Create brown-pants-press.md

MartinSchoeler added a commit that referenced this pull request Sep 18, 2024

feat: New tooltips and color behavior for private apps bar (#33243)

b25a4c4

* feat: New tooltips and behavior for private apps bar * Create brown-pants-press.md

MartinSchoeler added a commit that referenced this pull request Sep 18, 2024

feat: New tooltips and color behavior for private apps bar (#33243)

004e2d6

* feat: New tooltips and behavior for private apps bar * Create brown-pants-press.md

tassoevan pushed a commit that referenced this pull request Sep 30, 2024

feat: New tooltips and color behavior for private apps bar (#33243)

964bfd6

* feat: New tooltips and behavior for private apps bar * Create brown-pants-press.md

tassoevan pushed a commit that referenced this pull request Oct 1, 2024

feat: New tooltips and color behavior for private apps bar (#33243)

ab080c6

* feat: New tooltips and behavior for private apps bar * Create brown-pants-press.md

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: New tooltips and color behavior for private apps bar #33243

feat: New tooltips and color behavior for private apps bar #33243

MartinSchoeler commented Sep 10, 2024 •

edited by jira bot

Loading

changeset-bot bot commented Sep 10, 2024 •

edited

Loading

dionisio-bot bot commented Sep 10, 2024 •

edited

Loading

codecov bot commented Sep 10, 2024 •

edited

Loading

github-actions bot commented Sep 16, 2024 •

edited

Loading

feat: New tooltips and color behavior for private apps bar #33243

feat: New tooltips and color behavior for private apps bar #33243

Conversation

MartinSchoeler commented Sep 10, 2024 • edited by jira bot Loading

Proposed changes (including videos or screenshots)

Issue(s)

Further comments

changeset-bot bot commented Sep 10, 2024 • edited Loading

🦋 Changeset detected

dionisio-bot bot commented Sep 10, 2024 • edited Loading

codecov bot commented Sep 10, 2024 • edited Loading

Codecov Report

github-actions bot commented Sep 16, 2024 • edited Loading

MartinSchoeler commented Sep 10, 2024 •

edited by jira bot

Loading

changeset-bot bot commented Sep 10, 2024 •

edited

Loading

dionisio-bot bot commented Sep 10, 2024 •

edited

Loading

codecov bot commented Sep 10, 2024 •

edited

Loading

github-actions bot commented Sep 16, 2024 •

edited

Loading