feat!: E2EE room's Key icon no longer toggles encryption of room
#33572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 88e3232 The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
KevLehman
force-pushed
the
feat/remove-key-icon-click-behavior
branch
from
f472f1f
to
74e77b1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.0.0 #33572 +/- ##
=================================================
- Coverage 74.80% 74.79% -0.01%
=================================================
Files 467 467
Lines 20643 20641 -2
Branches 5263 5262 -1
=================================================
- Hits 15442 15439 -3
Misses 4590 4590
- Partials 611 612 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
KevLehman
force-pushed
the
feat/remove-key-icon-click-behavior
branch
from
3a1dc35
to
6cc9321
Compare
aleksandernsilva
requested changes
Oct 15, 2024
Co-authored-by: Aleksander Nicacio da Silva <[email protected]>
Co-authored-by: Aleksander Nicacio da Silva <[email protected]>
aleksandernsilva
previously approved these changes
Oct 15, 2024
aleksandernsilva
requested changes
Oct 15, 2024
aleksandernsilva
previously approved these changes
Oct 15, 2024
aleksandernsilva
approved these changes
Oct 15, 2024
KevLehman
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
ggazzo
pushed a commit
that referenced
this pull request
Oct 17, 2024
…33572) Co-authored-by: Aleksander Nicacio da Silva <[email protected]>
ggazzo
pushed a commit
that referenced
this pull request
Oct 17, 2024
…33572) Co-authored-by: Aleksander Nicacio da Silva <[email protected]>
ggazzo
pushed a commit
that referenced
this pull request
Oct 17, 2024
…33572) Co-authored-by: Aleksander Nicacio da Silva <[email protected]>
ggazzo
pushed a commit
that referenced
this pull request
Oct 17, 2024
…33572) Co-authored-by: Aleksander Nicacio da Silva <[email protected]>
This was referenced Oct 20, 2024
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This is a behavior change of the room header. Previously, room's encryption status could be disabled by clicking on the
Keyicon of the room header, given the user had permission. Now, the only way to toggle encryption of a room will be through the ellipsis menu.Button is no longer clickable and just serves as a visual cue that room is encrypted or not.
Issue(s)
https://rocketchat.atlassian.net/browse/E2EE2-77
Steps to test or reproduce
Further comments