feat(ui5-link, ui5-switch, ...): add focus support for mobile #9718
+22
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
didip1000
changed the title
hinzzx
requested changes
Aug 27, 2024
There was a problem hiding this comment.
- There are different styles (we are looking at the text underlining) when a Link is in
focusedstate and is being hovered upon; - When the Link is focused, the text is always being changed to white, while it should be considering the color (if being overstyled, check the second example);
Before (Correct behaviours)
After
|
@hinzzx We had a discussion with the Core team and we decided to proceed with the current solution, even if it removes the opportunity to overstyle the link directly when focused. The reasons discussed were that it can always be overstyled by changing the css variable value, which is the most common use case for us, and also is an edge case that will rarely be hit. Based on these two, we decided that this should not be stopper for us to continue with the implementation and review. You can proceed with the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like #8414,
LinkSwitch,ColorPicker, andTimeSelectionClockselements can now receive focus when using keyboards on mobile devices.Related to: #8322