fix(ui5-flexible-column-layout): iframe content no longer hinders resize #9859
+58
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kineticjs
changed the title
kineticjs
force-pushed
the
fcl-nested-iframe
branch
5 times, most recently
from
928764f
to
333cb9d
Compare
kineticjs
force-pushed
the
fcl-nested-iframe
branch
from
333cb9d
to
c995d81
Compare
kineticjs
force-pushed
the
fcl-nested-iframe
branch
from
2947d64
to
eaf879e
Compare
dobrinyonkov
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following issue:
When the user drags the column separator to resize some columns, the resize is interrupted if one of the resized columns contains an iframe and the mouse cursor does few pixels into the iframe content during resize (sample: https://js-lsv2ci.stackblitz.io/).
This happens because the mouse events in that moment get processed by the iframe and not by the main frame, so the main frame loses information on where the user is intending to move the separator (or if they released the mouse while the cursor was above the iframe).
Steps to reproduce:
Open sample: https://js-lsv2ci.stackblitz.io/ and drag to resize the column containing the pdf.
Solution:
Disable pointer events on columns during resizing to prevent unwanted interaction with the columns content.