Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: simplify guided prompt sample for dialog #9903

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kineticjs
Copy link
Contributor

@kineticjs kineticjs commented Sep 19, 2024

This simplifies the sample for guided prompt in dialog, to avoid issue #9902 untill the issue is fixed.

Steps to reproduce the issue in the sample for AI GuidedPrompt with dialog:

  1. Click the "Generate" ai-button to open a dialog
  2. In the dialog, click "Apply" and wait [few seconds] until the generation ends and the ai-button text becomes "Revise"
  3. Click the "Close" button to close the dialog
  4. Click the "Send" button at the footer => the user is notified that the message is sent and the form is cleared
  5. Repeat step 2 to re-open the dialog to compose new text
    Expected: In the dialog, the text of the ai-button is "Apply"
    Actual: the text of the ai-button is not entirely visible

With this change, clicking the footer "Send" button does not reset the state of the ai-button (as is also the case in the similar QuickPrompt sample) but the purpose of the sample is preserved.

@kineticjs kineticjs marked this pull request as ready for review September 19, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant