Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IT-3831] GH OIDC image builder deployments #1323

Merged
merged 1 commit into from
Jan 16, 2025
Merged

[IT-3831] GH OIDC image builder deployments #1323

merged 1 commit into from
Jan 16, 2025

Conversation

zaro0508
Copy link
Contributor

Instead of piggy backing on a packer role it's probably better to create a separate role for image builder deployments.

@zaro0508
[IT-3831] GH OIDC image builder deployments
6c0c671 
Instead of piggy backing on a packer role it's probably better to create
a separate role for image builder deployments.
@zaro0508 zaro0508 requested a review from a team as a code owner January 16, 2025 18:34
brucehoff
brucehoff approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@brucehoff brucehoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zaro0508 zaro0508 merged commit 31f4689 into Sage-Bionetworks-IT:master Jan 16, 2025
3 checks passed
zaro0508 added a commit to zaro0508/aws-ami-monorepo that referenced this pull request Jan 16, 2025
@zaro0508
[IT-3831] update role to deploy aws-ami-monorepo
0a0a1c9 
Created a new GH OIDC role for deployment therefore need to update the role
in this repo.

depends on Sage-Bionetworks-IT/organizations-infra#1323
@zaro0508 zaro0508 mentioned this pull request Jan 16, 2025
Merged
zaro0508 added a commit to Sage-Bionetworks-IT/aws-ami-monorepo that referenced this pull request Jan 16, 2025
@zaro0508
[IT-3831] update role to deploy aws-ami-monorepo (#5)
c3d011c 
Created a new GH OIDC role for deployment therefore need to update the role
in this repo.

depends on Sage-Bionetworks-IT/organizations-infra#1323
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ConsoleCatzirl ConsoleCatzirl ConsoleCatzirl approved these changes

@brucehoff brucehoff brucehoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zaro0508 @ConsoleCatzirl @brucehoff