-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dotnet 3.5 support #9
base: master
Are you sure you want to change the base?
Conversation
…l need to implement CurrentDictionary.
… appear to update these references when changed without restarting.
…mework and Samples are not built in the 3.5 configurations. Need to test on an 2003/XP machine.
I am not against this in principle, just needs careful review |
I completely understand; if I can be of any assistance please let me know. Likewise, let me know if you notice any bugs or poor design decisions and I'll fix them. Thanks! |
I'm also really interested in seeing a 3.5 SKU of this project. |
@RoryBecker As far I know, my personal fork works fine in 3.5; though I have not been keeping up with any changes to the core project. |
Hello,
I recently discovered the MvcMiniProfiler and love it but then noticed that it is .Net 4.0 only. Here is a simple attempt to remedy that. My goal was to have as minimal an impact on the existing code as possible and thus I centralized most of the changes into the DotNet35Support.cs file.
The major changes are:
IConcurrentDictionary<TKey, TValue>
interface and updated the SqlProfiler type to use it rather than the ConcurrentDictionary that is only included with .Net 4.0.MiniConcurrentDictionary<TKey, TValue>
type. This type is a very simple synchronized dictionary implementation for the 3.5 version, but should suffice for the required usage. The 4.0 version is simply a subtype ofSystem.Collections.Concurrent.ConcurrentDictionary
.I don't think the other changes are particularly notable and should be self-explanatory. Building a version that targets the 3.5 framework is as simple as changing the configuration to NET35-Debug or NET35-Release and building normally.
Note that I did not update the EF, LinqToSql, or sample projects to support 3.5 as that was out of the scope of my needs.
I hope this is helpful!