Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): Remove/rename native event names on every component #1799

Merged
merged 35 commits into from
Sep 17, 2024

Conversation

MajaZarkova
Copy link
Contributor

@MajaZarkova MajaZarkova commented Aug 26, 2024

Relates to #1603

Remove/rename native event names on every component

@MajaZarkova MajaZarkova requested a review from a team as a code owner August 26, 2024 13:16
Copy link

changeset-bot bot commented Aug 26, 2024

🦋 Changeset detected

Latest commit: bacbef4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
sit-onyx Major
demo-app Patch
playground Patch
@sit-onyx/chartjs-plugin Major
@sit-onyx/nuxt Major
@sit-onyx/storybook-utils Major
@sit-onyx/vitepress-theme Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MajaZarkova MajaZarkova marked this pull request as draft August 26, 2024 13:16
@MajaZarkova MajaZarkova changed the title feat(components): Remove/rename click event on every component feat(components): Remove/rename native event names on every component Aug 26, 2024
@MajaZarkova MajaZarkova marked this pull request as ready for review August 28, 2024 07:28
@larsrickert larsrickert self-assigned this Aug 29, 2024
@MajaZarkova MajaZarkova marked this pull request as draft September 2, 2024 10:41
@MajaZarkova MajaZarkova marked this pull request as ready for review September 4, 2024 07:02
@JoCa96 JoCa96 requested review from JoCa96 and removed request for JoCa96 September 12, 2024 09:54
Copy link
Collaborator

@larsrickert larsrickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also include a changeset with all breaking changes so the user knows which events he needs to rename when updating onyx

@JoCa96 JoCa96 enabled auto-merge (squash) September 13, 2024 12:41
JoCa96
JoCa96 previously approved these changes Sep 13, 2024
JoCa96
JoCa96 previously approved these changes Sep 16, 2024
@JoCa96 JoCa96 force-pushed the feat/1603-Remove/rename-native-event-names branch from 87910ad to 4542e4b Compare September 17, 2024 06:33
@JoCa96 JoCa96 merged commit e6af99b into main Sep 17, 2024
19 checks passed
@JoCa96 JoCa96 deleted the feat/1603-Remove/rename-native-event-names branch September 17, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants