Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(OnyxSelect): Implement storybook control type for modelValue #1878

Merged
merged 6 commits into from
Sep 18, 2024
Merged

chore(OnyxSelect): Implement storybook control type for modelValue #1878

merged 6 commits into from
Sep 18, 2024

Conversation

MajaZarkova
Copy link
Contributor

@MajaZarkova MajaZarkova commented Sep 17, 2024 •
edited
Loading

Relates to #1701

Implement storybook control type for modelValue

@MajaZarkova MajaZarkova requested a review from a team as a code owner September 17, 2024 07:38
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 17, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2b8da76

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@JoCa96 JoCa96 self-assigned this Sep 17, 2024
@JoCa96
Copy link
Contributor

JoCa96 commented Sep 17, 2024

On more thing: Please update the PR title to start with chore

@MajaZarkova MajaZarkova changed the title feat(OnyxSelect): Implement storybook control type for modelValue chore(OnyxSelect): Implement storybook control type for modelValue Sep 17, 2024
@MajaZarkova MajaZarkova enabled auto-merge (squash) September 18, 2024 06:28
@MajaZarkova MajaZarkova merged commit 9ad3123 into main Sep 18, 2024
19 checks passed
@MajaZarkova MajaZarkova deleted the feat/1701-implement-model-value-type-for-select branch September 18, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoCa96 JoCa96 JoCa96 approved these changes

Assignees

@JoCa96 JoCa96

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MajaZarkova @JoCa96