Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(icon-import): change alias separator to comma #1885

Merged
merged 5 commits into from
Sep 18, 2024
Merged

Conversation

larsrickert
Copy link
Collaborator

In our Figma icon file, not all icon aliases were separated correctly (some used |, others ,).
This is not aligned in Figma to always use comma so we also reflect this change in our CLI.

Checklist

  • A changeset is added with npx changeset add if your changes should be released as npm package (because they affect the library usage)

@larsrickert larsrickert requested a review from a team as a code owner September 18, 2024 09:42
Copy link

changeset-bot bot commented Sep 18, 2024

🦋 Changeset detected

Latest commit: 3d09bff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@sit-onyx/icons Minor
@sit-onyx/figma-utils Major
demo-app Patch
playground Patch
sit-onyx Major
@sit-onyx/storybook-utils Major
@sit-onyx/chartjs-plugin Major
@sit-onyx/nuxt Major
@sit-onyx/vitepress-theme Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JoCa96 JoCa96 self-assigned this Sep 18, 2024
@larsrickert larsrickert merged commit 33700f9 into main Sep 18, 2024
19 checks passed
@larsrickert larsrickert deleted the icon-aliases branch September 18, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants