You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds support for the provide response method and allows the provide_response method to be passed to response
it 'adds a response handler that provides a response' do
reset_driver!(web_socket_url: true) do |driver|
network = described_class.new(driver)
network.add_response_handler do |response|
response.status = 200
response.headers['foo'] = 'bar'
response.body = '<html><head><title>Hello World!</title></head><body/></html>'
response.provide_response
end
driver.navigate.to url_for('formPage.html')
expect(driver.page_source).to include('Hello World!')
end
end
def initialize(username: nil, password: nil)
+ if username || password+ raise ArgumentError, "Username must be a non-empty string" if username.nil? || username.empty?+ raise ArgumentError, "Password must be a non-empty string" if password.nil? || password.empty?+ end
@username = username
@password = password
end
Apply this suggestion
Suggestion importance[1-10]: 8
Why: The suggestion adds critical validation for authentication credentials, preventing potential security issues and authentication failures by ensuring credentials are non-empty strings when provided.
8
Add validation to ensure request ID is an integer to prevent type-related errors
The id method assumes @request['request'] returns an Integer but this is not validated. Add type checking and error handling to ensure the request ID is valid.
def id
- @id ||= @request['request']+ @id ||= begin+ request_id = @request['request']+ raise ArgumentError, 'Invalid request ID' unless request_id.is_a?(Integer)+ request_id+ end
end
Apply this suggestion
Suggestion importance[1-10]: 8
Why: The suggestion addresses a potential runtime error by adding type validation for the request ID, which is critical for proper object identification and could prevent hard-to-debug issues in production.
8
Add validation and error handling when setting request body to prevent runtime errors from invalid data
Add input validation for the body value to ensure it's in a valid format before serializing to JSON, as invalid data could cause runtime errors.
def body=(value)
- @body = {- type: 'string',- value: value.to_json- }+ raise ArgumentError, "Body value must not be nil" if value.nil?+ begin+ @body = {+ type: 'string',+ value: value.to_json+ }+ rescue JSON::GeneratorError => e+ raise ArgumentError, "Invalid body value: #{e.message}"+ end
end
Apply this suggestion
Suggestion importance[1-10]: 7
Why: The suggestion adds important input validation and error handling for the body setter method, which could prevent runtime errors and provide clearer error messages when invalid data is provided.
7
General
Add missing parameter type in method signature to prevent potential type errors
The body= method signature is incomplete - it's missing the parameter type which could lead to type-related bugs.
Why: The suggestion fixes an incomplete method signature in the type definition file, which is important for maintaining type safety and preventing potential type-related bugs during development.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aguspe
changed the title
User description
Description
This PR adds support for the provide response method and allows the provide_response method to be passed to response
network.provide_response:
Motivation and Context
This PR continues the work done on #14900 to add full access to all the BiDi network commands
Types of changes
Checklist
PR Type
Enhancement, Tests
Description
Introduced BiDi network interception capabilities for requests and responses.
Added support for authentication handling, including skipping, canceling, and providing credentials.
Implemented serialization for cookies, headers, and set-cookie headers.
Enhanced test coverage for BiDi network features and added unit tests for new components.
Changes walkthrough 📝
14 files
Added autoload for new BiDi network interception classesEnhanced BiDi network with interception and response handlingAdded cookie serialization support for BiDi networkAdded credentials handling for BiDi network authenticationAdded header serialization support for BiDi networkAdded intercepted authentication handling for BiDi networkIntroduced base class for intercepted network itemsAdded intercepted request handling for BiDi networkAdded intercepted response handling for BiDi networkAdded set-cookie header serialization for BiDi networkAdded URL pattern formatting for BiDi network interceptionIntegrated BiDi network interception into common network moduleUpdated BiDi type signatures for new capabilitiesAdded type signatures for BiDi network interception methods6 files
Added integration tests for BiDi network interceptionEnhanced integration tests for network handlersAdded unit tests for cookie serializationAdded unit tests for credentials handlingAdded unit tests for header serializationAdded unit tests for set-cookie header serialization11 files