Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dotnet] Update Moq test dependency #15085

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

RenderMichael
Copy link
Contributor

@RenderMichael RenderMichael commented Jan 14, 2025

User description

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

Enhancement, Tests


Description

  • Updated Moq dependency to version 4.20.72 across multiple files.

  • Adjusted dependency configurations in paket.nuget.bzl and paket.dependencies.

  • Updated project files to reflect the new Moq version.

  • Ensured compatibility with the new Moq version in test projects.


Changes walkthrough 📝

Relevant files
Enhancement
paket.nuget.bzl
Update `Moq` dependency in `paket.nuget.bzl`                         

dotnet/paket.nuget.bzl

  • Updated Moq dependency version from 4.12.0 to 4.20.72.
  • Adjusted dependency details such as sha512 and framework
    compatibility.
  • +1/-1     
    workspace.bzl
    Update `Moq` package reference in `workspace.bzl`               

    dotnet/workspace.bzl

  • Updated Moq package file reference to version 4.20.72.
  • Adjusted sha256 checksum for the new package.
  • +1/-1     
    paket.dependencies
    Update `Moq` version in `paket.dependencies`                         

    dotnet/paket.dependencies

    • Updated Moq dependency version from 4.12.0 to 4.20.72.
    +1/-1     
    Tests
    WebDriver.Common.Tests.csproj
    Update `Moq` version in `WebDriver.Common.Tests.csproj`   

    dotnet/test/common/WebDriver.Common.Tests.csproj

    • Updated Moq package reference version from 4.13.0 to 4.20.72.
    +1/-1     
    WebDriver.Support.Tests.csproj
    Update `Moq` version in `WebDriver.Support.Tests.csproj` 

    dotnet/test/support/WebDriver.Support.Tests.csproj

    • Updated Moq package reference version from 4.13.0 to 4.20.72.
    +1/-1     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link
    Contributor

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @nvborisenko
    Copy link
    Member

    Blocked by #15063

    Copy link
    Member

    @nvborisenko nvborisenko Jan 17, 2025

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    What if net 8.0 instead of 7.0 at the top of the file?

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants