Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Prepare for release of Selenium 4.28.0 #15098

Draft
wants to merge 12 commits into
base: trunk
Choose a base branch
from

Conversation

selenium-ci
Copy link
Member

Warning: Manually update the changelogs before merging

This PR:

  • Updates Rust version for Selenium Manager release
  • Updates Pinned browser version to coincide with new CDP release
  • Adds support for new CDP version and removes old CDP version
  • Selenium Manager references the new Selenium Manager release
  • Updates Maven Dependencies
  • Adds new authors to authors file
  • Updates all versions for all bindings
  • Generates rough change logs for each bindings (please tidy them up before merging this)

@selenium-ci selenium-ci added the C-build Build related issues (bazel and CI) label Jan 16, 2025
Copy link
Contributor

qodo-merge-pro bot commented Jan 16, 2025

CI Failure Feedback 🧐

(Checks updated until commit e236c36)

Action: Java / Browser Tests (windows) / Browser Tests (chrome, windows)

Failed stage: Run Bazel [❌]

Failed test name: ChromeDriverFunctionalTest

Failure summary:

The action failed because the ChromeDriverFunctionalTest test suite failed with 7 failures. The main
failure appears to be in the shouldThrowNumberFormatException() test where there was an assertion
error comparing error messages related to Arabic language port number formatting. The test expected
and actual messages appear identical but the test still failed, suggesting potential invisible
character differences or encoding issues.

Relevant error logs:
1:  ##[group]Operating System
2:  Microsoft Windows Server 2022
...

638:  cl : Command line warning D9002 : ignoring unknown option '-std=c++14'
639:  �[32mINFO: �[0mFrom Compiling absl/base/internal/throw_delegate.cc [for tool]:
640:  cl : Command line warning D9002 : ignoring unknown option '-std=c++14'
641:  �[32mINFO: �[0mFrom Compiling absl/base/internal/spinlock_wait.cc [for tool]:
642:  cl : Command line warning D9002 : ignoring unknown option '-std=c++14'
643:  �[32mINFO: �[0mFrom Compiling absl/log/internal/conditions.cc [for tool]:
644:  cl : Command line warning D9002 : ignoring unknown option '-std=c++14'
645:  �[32mINFO: �[0mFrom Building java/src/org/openqa/selenium/remote/libapi-class.jar (71 source files):
646:  java\src\org\openqa\selenium\remote\ErrorHandler.java:46: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal
647:  private final ErrorCodes errorCodes;
648:  ^
649:  java\src\org\openqa\selenium\remote\ErrorHandler.java:60: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal
650:  this.errorCodes = new ErrorCodes();
651:  ^
652:  java\src\org\openqa\selenium\remote\ErrorHandler.java:68: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal
653:  public ErrorHandler(ErrorCodes codes, boolean includeServerErrors) {
654:  ^
655:  java\src\org\openqa\selenium\remote\Response.java:97: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal
656:  ErrorCodes errorCodes = new ErrorCodes();
657:  ^
658:  java\src\org\openqa\selenium\remote\Response.java:97: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal
659:  ErrorCodes errorCodes = new ErrorCodes();
660:  ^
661:  java\src\org\openqa\selenium\remote\ProtocolHandshake.java:181: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal
662:  response.setStatus(ErrorCodes.SUCCESS);
663:  ^
664:  java\src\org\openqa\selenium\remote\ProtocolHandshake.java:182: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal
665:  response.setState(ErrorCodes.SUCCESS_STRING);
666:  ^
667:  java\src\org\openqa\selenium\remote\W3CHandshakeResponse.java:53: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal
668:  new ErrorCodes().toStatus((String) rawError, Optional.of(tuple.getStatusCode())));
669:  ^
670:  java\src\org\openqa\selenium\remote\W3CHandshakeResponse.java:56: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal
671:  new ErrorCodes().getExceptionType((String) rawError);
672:  ^
673:  java\src\org\openqa\selenium\remote\codec\AbstractHttpResponseCodec.java:44: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal
674:  private final ErrorCodes errorCodes = new ErrorCodes();
675:  ^
676:  java\src\org\openqa\selenium\remote\codec\AbstractHttpResponseCodec.java:44: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal
677:  private final ErrorCodes errorCodes = new ErrorCodes();
678:  ^
679:  java\src\org\openqa\selenium\remote\codec\AbstractHttpResponseCodec.java:55: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal
680:  int status = response.getStatus() == ErrorCodes.SUCCESS ? HTTP_OK : HTTP_INTERNAL_ERROR;
681:  ^
682:  java\src\org\openqa\selenium\remote\codec\AbstractHttpResponseCodec.java:101: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal
683:  response.setStatus(ErrorCodes.UNKNOWN_COMMAND);
684:  ^
685:  java\src\org\openqa\selenium\remote\codec\AbstractHttpResponseCodec.java:103: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal
686:  response.setStatus(ErrorCodes.UNHANDLED_ERROR);
687:  ^
688:  java\src\org\openqa\selenium\remote\codec\AbstractHttpResponseCodec.java:117: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal
689:  response.setStatus(ErrorCodes.SUCCESS);
690:  ^
691:  java\src\org\openqa\selenium\remote\codec\AbstractHttpResponseCodec.java:118: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal
692:  response.setState(errorCodes.toState(ErrorCodes.SUCCESS));
693:  ^
694:  java\src\org\openqa\selenium\remote\codec\AbstractHttpResponseCodec.java:124: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal
695:  response.setState(errorCodes.toState(ErrorCodes.SUCCESS));
696:  ^
697:  java\src\org\openqa\selenium\remote\codec\w3c\W3CHttpResponseCodec.java:70: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal
698:  private final ErrorCodes errorCodes = new ErrorCodes();
699:  ^
700:  java\src\org\openqa\selenium\remote\codec\w3c\W3CHttpResponseCodec.java:70: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal
701:  private final ErrorCodes errorCodes = new ErrorCodes();
702:  ^
703:  java\src\org\openqa\selenium\remote\codec\w3c\W3CHttpResponseCodec.java:93: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal
704:  response.setStatus(ErrorCodes.UNKNOWN_COMMAND);
705:  ^
706:  java\src\org\openqa\selenium\remote\codec\w3c\W3CHttpResponseCodec.java:98: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal
707:  response.setStatus(ErrorCodes.UNHANDLED_ERROR);
708:  ^
709:  java\src\org\openqa\selenium\remote\codec\w3c\W3CHttpResponseCodec.java:145: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal
710:  response.setStatus(ErrorCodes.SUCCESS);
...

886:  �[32mINFO: �[0mFrom Compiling absl/log/internal/log_format.cc [for tool]:
887:  cl : Command line warning D9002 : ignoring unknown option '-std=c++14'
888:  �[32mINFO: �[0mFrom Compiling absl/strings/internal/cordz_functions.cc [for tool]:
889:  cl : Command line warning D9002 : ignoring unknown option '-std=c++14'
890:  �[32mINFO: �[0mFrom Compiling src/google/protobuf/compiler/rust/relative_path.cc [for tool]:
891:  cl : Command line warning D9002 : ignoring unknown option '-std=c++14'
892:  �[32mINFO: �[0mFrom Compiling absl/container/internal/raw_hash_set.cc [for tool]:
893:  cl : Command line warning D9002 : ignoring unknown option '-std=c++14'
894:  �[32mINFO: �[0mFrom Compiling absl/base/internal/strerror.cc [for tool]:
...

1609:  �[32mINFO: �[0mFrom Linking external/protobuf~/protoc.exe [for tool]:
1610:  LINK : warning LNK4001: no object files specified; libraries used
1611:  �[32mINFO: �[0mFrom Building external/protobuf~/java/core/libcore.jar (43 source files, 1 source jar) [for tool]:
1612:  external\protobuf~\java\core\src\main\java\com\google\protobuf\RepeatedFieldBuilderV3.java:28: warning: [dep-ann] deprecated item is not annotated with @Deprecated
1613:  public class RepeatedFieldBuilderV3<
1614:  ^
1615:  �[32m[2,210 / 2,409]�[0m Extracting npm package @mui/[email protected]_60647716; 3s disk-cache ... (2 actions, 0 running)
1616:  �[32mINFO: �[0mFrom Building java/test/org/openqa/selenium/remote/libsmall-tests-test-lib.jar (5 source files) and running annotation processors (AutoServiceProcessor):
1617:  java\test\org\openqa\selenium\remote\WebDriverFixture.java:170: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal
1618:  response.setStatus(new ErrorCodes().toStatus(state, Optional.of(400)));
...

1626:  �[32m[2,413 / 2,414]�[0m 4 / 5 tests;�[0m Testing //java/test/org/openqa/selenium/chrome:ChromeDriverFunctionalTest; 1s local, disk-cache
1627:  �[31m�[1mFAIL: �[0m//java/test/org/openqa/selenium/chrome:ChromeDriverFunctionalTest (see D:/_bazel/execroot/_main/bazel-out/x64_windows-fastbuild/testlogs/java/test/org/openqa/selenium/chrome/ChromeDriverFunctionalTest/test_attempts/attempt_1.log)
1628:  �[32m[2,413 / 2,414]�[0m 4 / 5 tests;�[0m Testing //java/test/org/openqa/selenium/chrome:ChromeDriverFunctionalTest; 2s local, disk-cache
1629:  �[32m[2,413 / 2,414]�[0m 4 / 5 tests;�[0m Testing //java/test/org/openqa/selenium/chrome:ChromeDriverFunctionalTest; 4s local, disk-cache
1630:  �[31m�[1mFAIL: �[0m//java/test/org/openqa/selenium/chrome:ChromeDriverFunctionalTest (see D:/_bazel/execroot/_main/bazel-out/x64_windows-fastbuild/testlogs/java/test/org/openqa/selenium/chrome/ChromeDriverFunctionalTest/test_attempts/attempt_2.log)
1631:  �[32m[2,413 / 2,414]�[0m 4 / 5 tests;�[0m Testing //java/test/org/openqa/selenium/chrome:ChromeDriverFunctionalTest; 5s local, disk-cache
1632:  �[32m[2,413 / 2,414]�[0m 4 / 5 tests;�[0m Testing //java/test/org/openqa/selenium/chrome:ChromeDriverFunctionalTest; 7s local, disk-cache
1633:  �[31m�[1mFAIL: �[0m//java/test/org/openqa/selenium/chrome:ChromeDriverFunctionalTest (see D:/_bazel/execroot/_main/bazel-out/x64_windows-fastbuild/testlogs/java/test/org/openqa/selenium/chrome/ChromeDriverFunctionalTest/test.log)
1634:  �[31m�[1mFAILED: �[0m//java/test/org/openqa/selenium/chrome:ChromeDriverFunctionalTest (Summary)
1635:  D:/_bazel/execroot/_main/bazel-out/x64_windows-fastbuild/testlogs/java/test/org/openqa/selenium/chrome/ChromeDriverFunctionalTest/test.log
1636:  D:/_bazel/execroot/_main/bazel-out/x64_windows-fastbuild/testlogs/java/test/org/openqa/selenium/chrome/ChromeDriverFunctionalTest/test_attempts/attempt_1.log
1637:  D:/_bazel/execroot/_main/bazel-out/x64_windows-fastbuild/testlogs/java/test/org/openqa/selenium/chrome/ChromeDriverFunctionalTest/test_attempts/attempt_2.log
1638:  �[32mINFO: �[0mFrom Testing //java/test/org/openqa/selenium/chrome:ChromeDriverFunctionalTest:
1639:  ==================== Test output for //java/test/org/openqa/selenium/chrome:ChromeDriverFunctionalTest:
1640:  Failures: 7
1641:  ?) shouldThrowNumberFormatException() (org.openqa.selenium.chrome.ChromeDriverFunctionalTest)
1642:  org.opentest4j.AssertionFailedError: 
1643:  Expecting message to be:
1644:  "Couldn't format the port numbers because the System Language is arabic: "--port=?????", please make sure to add the required arguments "-Duser.language=en -Duser.region=US" to your JVM, for more info please visit :
1645:  https://www.selenium.dev/documentation/webdriver/browsers/"
1646:  but was:
1647:  "Couldn't format the port numbers because the System Language is arabic: "--port=?????", please make sure to add the required arguments "-Duser.language=en -Duser.region=US" to your JVM, for more info please visit :
1648:  https://www.selenium.dev/documentation/webdriver/browsers/"
1649:  Throwable that failed the check:
...

1786:  at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
1787:  at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921)
1788:  at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
1789:  at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:682)
1790:  at org.openqa.selenium.remote.RemoteWebDriverBuilder.getLocalDriver(RemoteWebDriverBuilder.java:310)
1791:  at org.openqa.selenium.remote.RemoteWebDriverBuilder.build(RemoteWebDriverBuilder.java:364)
1792:  at org.openqa.selenium.chrome.ChromeDriverFunctionalTest.builderOverridesDefaultChromeOptions(ChromeDriverFunctionalTest.java:71)
1793:  ?) driverOverridesDefaultClientConfig() (org.openqa.selenium.chrome.ChromeDriverFunctionalTest)
1794:  java.lang.AssertionError: 
...

1873:  at org.openqa.selenium.testing.JupiterTestBase.prepareEnvironment(JupiterTestBase.java:84)
1874:  at java.base/java.lang.reflect.Method.invoke(Method.java:568)
1875:  at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
1876:  at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
1877:  ================================================================================
1878:  ==================== Test output for //java/test/org/openqa/selenium/chrome:ChromeDriverFunctionalTest:
1879:  Failures: 7
1880:  ?) shouldThrowNumberFormatException() (org.openqa.selenium.chrome.ChromeDriverFunctionalTest)
1881:  org.opentest4j.AssertionFailedError: 
1882:  Expecting message to be:
1883:  "Couldn't format the port numbers because the System Language is arabic: "--port=?????", please make sure to add the required arguments "-Duser.language=en -Duser.region=US" to your JVM, for more info please visit :
1884:  https://www.selenium.dev/documentation/webdriver/browsers/"
1885:  but was:
1886:  "Couldn't format the port numbers because the System Language is arabic: "--port=?????", please make sure to add the required arguments "-Duser.language=en -Duser.region=US" to your JVM, for more info please visit :
1887:  https://www.selenium.dev/documentation/webdriver/browsers/"
1888:  Throwable that failed the check:
...

2025:  at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
2026:  at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921)
2027:  at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
2028:  at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:682)
2029:  at org.openqa.selenium.remote.RemoteWebDriverBuilder.getLocalDriver(RemoteWebDriverBuilder.java:310)
2030:  at org.openqa.selenium.remote.RemoteWebDriverBuilder.build(RemoteWebDriverBuilder.java:364)
2031:  at org.openqa.selenium.chrome.ChromeDriverFunctionalTest.builderOverridesDefaultChromeOptions(ChromeDriverFunctionalTest.java:71)
2032:  ?) driverOverridesDefaultClientConfig() (org.openqa.selenium.chrome.ChromeDriverFunctionalTest)
2033:  java.lang.AssertionError: 
...

2112:  at org.openqa.selenium.testing.JupiterTestBase.prepareEnvironment(JupiterTestBase.java:84)
2113:  at java.base/java.lang.reflect.Method.invoke(Method.java:568)
2114:  at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
2115:  at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
2116:  ================================================================================
2117:  ==================== Test output for //java/test/org/openqa/selenium/chrome:ChromeDriverFunctionalTest:
2118:  Failures: 7
2119:  ?) shouldThrowNumberFormatException() (org.openqa.selenium.chrome.ChromeDriverFunctionalTest)
2120:  org.opentest4j.AssertionFailedError: 
2121:  Expecting message to be:
2122:  "Couldn't format the port numbers because the System Language is arabic: "--port=?????", please make sure to add the required arguments "-Duser.language=en -Duser.region=US" to your JVM, for more info please visit :
2123:  https://www.selenium.dev/documentation/webdriver/browsers/"
2124:  but was:
2125:  "Couldn't format the port numbers because the System Language is arabic: "--port=?????", please make sure to add the required arguments "-Duser.language=en -Duser.region=US" to your JVM, for more info please visit :
2126:  https://www.selenium.dev/documentation/webdriver/browsers/"
2127:  Throwable that failed the check:
...

2264:  at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
2265:  at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921)
2266:  at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
2267:  at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:682)
2268:  at org.openqa.selenium.remote.RemoteWebDriverBuilder.getLocalDriver(RemoteWebDriverBuilder.java:310)
2269:  at org.openqa.selenium.remote.RemoteWebDriverBuilder.build(RemoteWebDriverBuilder.java:364)
2270:  at org.openqa.selenium.chrome.ChromeDriverFunctionalTest.builderOverridesDefaultChromeOptions(ChromeDriverFunctionalTest.java:71)
2271:  ?) driverOverridesDefaultClientConfig() (org.openqa.selenium.chrome.ChromeDriverFunctionalTest)
2272:  java.lang.AssertionError: 
...

2351:  at org.openqa.selenium.testing.JupiterTestBase.prepareEnvironment(JupiterTestBase.java:84)
2352:  at java.base/java.lang.reflect.Method.invoke(Method.java:568)
2353:  at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
2354:  at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
2355:  ================================================================================
2356:  �[32mINFO: �[0mFound 5 test targets...
2357:  �[32mINFO: �[0mElapsed time: 85.163s, Critical Path: 12.75s
2358:  �[32mINFO: �[0m2153 processes: 1346 disk cache hit, 787 internal, 20 local.
2359:  �[32mINFO: �[0mBuild completed, 1 test FAILED, 2153 total actions
2360:  //java/test/org/openqa/selenium/federatedcredentialmanagement:FederatedCredentialManagementTest �[0m�[32m(cached) PASSED�[0m in 73.9s
2361:  //java/test/org/openqa/selenium/firefox:FirefoxDriverBuilderTest �[0m�[32m(cached) PASSED�[0m in 80.4s
2362:  //java/test/org/openqa/selenium/grid/router:RemoteWebDriverDownloadTest �[0m�[32m(cached) PASSED�[0m in 97.3s
2363:  //java/test/org/openqa/selenium/remote:RemoteWebDriverBuilderTest �[0m�[32m(cached) PASSED�[0m in 19.1s
2364:  //java/test/org/openqa/selenium/chrome:ChromeDriverFunctionalTest        �[0m�[31m�[1mFAILED�[0m in 3 out of 3 in 2.8s
2365:  Stats over 3 runs: max = 2.8s, min = 2.8s, avg = 2.8s, dev = 0.0s
2366:  D:/_bazel/execroot/_main/bazel-out/x64_windows-fastbuild/testlogs/java/test/org/openqa/selenium/chrome/ChromeDriverFunctionalTest/test.log
2367:  D:/_bazel/execroot/_main/bazel-out/x64_windows-fastbuild/testlogs/java/test/org/openqa/selenium/chrome/ChromeDriverFunctionalTest/test_attempts/attempt_1.log
2368:  D:/_bazel/execroot/_main/bazel-out/x64_windows-fastbuild/testlogs/java/test/org/openqa/selenium/chrome/ChromeDriverFunctionalTest/test_attempts/attempt_2.log
2369:  Executed 1 out of 5 tests: 4 tests pass and �[0m�[31m�[1m1 fails locally�[0m.
2370:  There were tests whose specified size is too big. Use the --test_verbose_timeout_warnings command line option to see which ones these are.
2371:  �[0m
2372:  ##[error]Process completed with exit code 1.

✨ CI feedback usage guide:

The CI feedback tool (/checks) automatically triggers when a PR has a failed check.
The tool analyzes the failed checks and provides several feedbacks:

  • Failed stage
  • Failed test name
  • Failure summary
  • Relevant error logs

In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:

/checks "https://github.com/{repo_name}/actions/runs/{run_number}/job/{job_number}"

where {repo_name} is the name of the repository, {run_number} is the run number of the failed check, and {job_number} is the job number of the failed check.

Configuration options

  • enable_auto_checks_feedback - if set to true, the tool will automatically provide feedback when a check is failed. Default is true.
  • excluded_checks_list - a list of checks to exclude from the feedback, for example: ["check1", "check2"]. Default is an empty list.
  • enable_help_text - if set to true, the tool will provide a help message with the feedback. Default is true.
  • persistent_comment - if set to true, the tool will overwrite a previous checks comment with the new feedback. Default is true.
  • final_update_message - if persistent_comment is true and updating a previous checks message, the tool will also create a new message: "Persistent checks updated to latest commit". Default is true.

See more information about the checks tool in the docs.

diemol and others added 6 commits January 16, 2025 12:09
* Update Gemfile.lock and checksums

* Platform added and tested locally

* FIx rubocop issues

* Push new platform and module

* Formatting fixed

* Add missing platforms and fix module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-build Build related issues (bazel and CI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants