forked from electron/electron
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: do not resolve electron entrypoints on disk (electron#39247)
- Loading branch information
1 parent
695fcf3
commit 8dea783
Showing
2 changed files
with
25 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 changes: 24 additions & 0 deletions
24
patches/node/fix_do_not_resolve_electron_entrypoints.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 | ||
From: Samuel Attard <[email protected]> | ||
Date: Wed, 26 Jul 2023 17:03:15 -0700 | ||
Subject: fix: do not resolve electron entrypoints | ||
|
||
This wastes fs cycles and can result in strange behavior if this path actually exists on disk | ||
|
||
diff --git a/lib/internal/modules/run_main.js b/lib/internal/modules/run_main.js | ||
index 5a50d5d6afab6e6648f72a1c0efa1df4cd80bcd9..0be45309028b00a6957ee473322a9452a7fa7d67 100644 | ||
--- a/lib/internal/modules/run_main.js | ||
+++ b/lib/internal/modules/run_main.js | ||
@@ -13,6 +13,12 @@ const { | ||
} = require('internal/modules/esm/handle_process_exit'); | ||
|
||
function resolveMainPath(main) { | ||
+ // For built-in modules used as the main entry point we _never_ | ||
+ // want to waste cycles resolving them to file paths on disk | ||
+ // that actually might exist | ||
+ if (typeof main === 'string' && main.startsWith('electron/js2c')) { | ||
+ return main; | ||
+ } | ||
// Note extension resolution for the main entry point can be deprecated in a | ||
// future major. | ||
// Module._findPath is monkey-patchable here. |