Refactor to decouple ASCII and Meta protocols #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrattle
force-pushed
the
mrattle/implement-meta-set
branch
from
bbd5c9c
to
477ef91
Compare
mrattle
force-pushed
the
mrattle/implement-meta-set
branch
3 times, most recently
from
efb5ba2
to
1f31e1f
Compare
mrattle
force-pushed
the
mrattle/decouple-ascii-meta-protos
branch
from
7b58d0d
to
24f76a8
Compare
mrattle
force-pushed
the
mrattle/decouple-ascii-meta-protos
branch
2 times, most recently
from
11bfb91
to
7db4f34
Compare
mrattle
changed the title
mrattle
force-pushed
the
mrattle/decouple-ascii-meta-protos
branch
from
7db4f34
to
0469f4d
Compare
mrattle
force-pushed
the
mrattle/decouple-ascii-meta-protos
branch
from
0469f4d
to
b16eb44
Compare
mrattle
force-pushed
the
mrattle/decouple-ascii-meta-protos
branch
from
2aa3cb2
to
35b5d44
Compare
nickamorim
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR - What are you trying to accomplish?
This PR splits the ASCII and Meta protocols into their own separate files. More changes will be made to split tests and benchmarks apart into separate files as well, since those files are also becoming bloated as the crate has expanded.
The
Valuestruct has been returns to its original form, from before the meta protocol implementation began. TheMetaValuestruct has been expanded to include all fields and take a flat structure, instead of the nested structure that the initial implementations used. This has allowed for some simplification in other parts of the code that maps meta flags once they're parsed.Details - How are you making this change? What are the effects of this change?
Impl traits on the
Clientfor bothAsciiProtocolandMetaProtocolallow things to be split apart.