Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Could not use theme dev since CLI 3.67 #4477

Closed
2 tasks done
bakura10 opened this issue Sep 19, 2024 · 3 comments · Fixed by #4490
Closed
2 tasks done

[Bug]: Could not use theme dev since CLI 3.67 #4477

bakura10 opened this issue Sep 19, 2024 · 3 comments · Fixed by #4490
Assignees
Labels
Area: @shopify/theme @shopify/theme package issues #gsd:40767 Fortify local development experience for Liquid themes important second highest severity for theme related bug Type: Bug Something isn't working

Comments

@bakura10
Copy link

bakura10 commented Sep 19, 2024

Please confirm that you have:

  • Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
  • Reproduced the issue in the latest CLI version.

In which of these areas are you experiencing a problem?

Theme

Expected behavior

Hi,

After upgrading to Shopify CLI 3.67, the CLI asked for a new "store-password" for password protected storefront. I've entered it, but now I am facing a different issue that I can't understand:

Your development session could not be created because the "_shopify_essential" could not be defined. Please, check your internet connection.

Reverting to Shopify CLI 3.66 fixes the issue.
EDIT: might be related to #4471, but the error I get is different.

Actual behavior

I can't use dev commands for theme.

Please note that I'm using the --environment option to pull the env data from a shopify.theme.toml file

Verbose output

Request to https://theme-kit-access.shopifyapps.com/cli/sfr?preview_theme_id=158896423231&_fd=0&pb=0 completed in 296 ms
With response headers:

  • cache-control: no-cache
  • content-type: application/json; charset=utf-8
  • server-timing: processing;dur=6, socket_queue;dur=8.119, cfRequestDuration;dur=215.000153
  • x-request-id: f19074d8-2ee4-44d1-b664-db8129a3a277-1726734286

Error

Your development session could not be created because the "_shopify_essential" could not be defined. Please, check your internet connection.

Reproduction steps

  1. Use shopify theme dev command

Operating System

OSX 15

Shopify CLI version (check your project's package.json if you're not sure)

3.67

Shell

No response

Node version (run node -v if you're not sure)

No response

What language and version are you using in your application?

No response

@bakura10 bakura10 added the Type: Bug Something isn't working label Sep 19, 2024
@darrencraig
Copy link

Same issue - seems to be the way authentication is now handled. I was using Theme Password, but this now seems to be cookie based.

My command was -

"scripts": {
        "shopify:dev": "source .env && shopify theme dev --store $STORE_URL --theme-editor-sync --password $THEME_PASSWORD",
}

I have now switched it to

"scripts": {
        "shopify:dev": "source .env && shopify theme dev --store $STORE_URL --theme-editor-sync",
}

After logging in again, things appear to be working as expected.

@karreiro karreiro self-assigned this Sep 19, 2024
@karreiro karreiro added important second highest severity for theme related bug #gsd:40767 Fortify local development experience for Liquid themes Area: @shopify/theme @shopify/theme package issues labels Sep 19, 2024
@karreiro
Copy link
Contributor

Thank you for reporting this issue, @bakura10 @darrencraig! We're taking a look at it.

While that's not fixed, could you please confirm if the --legacy flag works as a temporary workaround for you? This flag will activate the previous implementation for the command and should unblock your workflow.

Thank you for reporting!

@bakura10
Copy link
Author

Yes legacy works as expected ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: @shopify/theme @shopify/theme package issues #gsd:40767 Fortify local development experience for Liquid themes important second highest severity for theme related bug Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants