Fix Theme Access authentication on shopify theme dev and shopify theme console commands
#4490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…heme console` commands.
|
Thanks for your contribution! Depending on what you are working on, you may want to request a review from a Shopify team:
|
Coverage report
Test suite run success1889 tests passing in 857 suites. Report generated by 🧪jest coverage report action from cce54b1 |
frandiox
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #4477
The
shopify theme consolecommand was failing since this change, because the Theme Access requests need theAuthorizationheader.WHAT is this pull request doing?
This PR now just passes the
Authorizationheader as we already have it at the moment the session is initialized.This PR also avoids propagating the content-type of the SFR response, because when it's being proxied by the Theme Access app, that content-type is set to
application/json(we're not introducing any branching code here, to protect the CLI from future changes, and in the end, the content-type should never beapplication/json).How to test your changes?
Use the following command passing the Theme Access token:
shopify theme dev --password <your_theme_access_password> --store <your_store>shopify theme console --password <your_theme_access_password> --store <your_store>Before:
After:
Post-release steps
N/a
Measuring impact
How do we know this change was effective? Please choose one:
Checklist