Fix regexp patterns for block parameters #3212
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
close #3184
close #3211
VS Code plugin does not highlight the cases below.
|
with two or more spaces before itImplementation
For first issue, I changed the pattern to check variable type.
Before:
ruby-lsp/vscode/grammars/ruby.cson.json
Line 2263 in 841e92c
After:
https://github.com/taichi-ishitani/ruby-lsp/blob/d325628031b55e434525804356ccd7324131d0cf/vscode/grammars/ruby.cson.json#L2263
For second issue, I added the
+
quantification to the whitespace pattern within the beginning pattern of the block parameters.Automated Tests
Manual Tests
I ran the extension and confirmed that such blocks are highlighted correctly.
