Fix: allow custom date/time input in range picker #6952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 7417392 in 1 minute and 29 seconds
More details
- Looked at
22lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. frontend/src/components/CustomTimePicker/RangePickerModal.tsx:69
- Draft comment:
Removing theformatprop might lead to unexpected date/time formats being displayed. Ensure that the default format is acceptable for the application's requirements. - Reason this comment was not posted:
Comment did not seem useful.
2. frontend/src/components/CustomTimePicker/RangePickerModal.tsx:1
- Draft comment:
Avoid using thecomponent/index.tsxfile structure approach, as it makes it difficult to debug and find components using global search tools like VS Code. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_E5v46Jh5KKCOMOfJ
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
amlannandy
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Issues / PR's
Part of https://github.com/SigNoz/engineering-pod/issues/2155
Screenshots
Before:
2025-01-28.10-21-14.mov
After:
2025-01-28.10-21-36.mov
Affected Areas and Manually Tested Areas
Important
Removed custom date/time format in
RangePickerModal.tsx, allowing default format inRangePicker.RangePickerModal.tsx, allowing default format inRangePicker.formatprop fromRangePickerinRangePickerModal()function.This description was created by
for 7417392. It will automatically update as commits are pushed.