POC for Winget Depends Launcher needs winget removed too #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can simplify the winget dependencies for you. After checking the Installer.bat and moving to Launcher.bat, I noticed it's installing about 10 other apps with winget... The colors are off and it installs get every time but you get the point.
Love the .bat colors it's a lot easier to do all that in powershell ... took me like 5+ years to stop using .bat so I know how it feels. I still use .bat to call powershell sometimes to bypass EDR ...
Other items need winget depends removed:
1833: winget install -e --id 7zip.7zip # https://github.com/freeload101/Java-Android-Magisk-Burp-Objection-Root-Emulator-Easy/blob/c4ea1a3b309a41e43386eb2b8ee18459118f8465/JAMBOREE.ps1#L1531
Line 1940: winget install -e --id OpenJS.NodeJS # wait ..
Line 1948: winget install -e --id MikeFarah.yq # IDK ..
Line 2488: winget uninstall --id 7zip.7zip # https://github.com/freeload101/Java-Android-Magisk-Burp-Objection-Root-Emulator-Easy/blob/c4ea1a3b309a41e43386eb2b8ee18459118f8465/JAMBOREE.ps1#L1531
Line 2504: winget uninstall --id OpenJS.NodeJS # wait again ? I think the dupe code can be conbined by using call and exit codes Referernce https://github.com/freeload101/Bloodhound-Portable/blob/fb3db2dad0b182a86683acf56310d29a41ba7e62/BloodHound_Portable.bat#L53
Line 2513: winget uninstall --id MikeFarah.yq # no idea on this one
Line 2522: winget uninstall --id Nvidia.CUDA ## IDK how to know what ver of cuda to install ?!
Line 2530: winget uninstall --id Microsoft.VisualStudio.2022.BuildTools # fixed in installer.bat