fix: move default config to class #617
Conversation
|
there should be a config rewrite tbh |
ButterscotchV
added
Priority: Low
|
I did it like how it is because it didn't work properly otherwise. Is this tested? |
| private var portIn: Int = 39540 | ||
| private var portOut: Int = 39539 | ||
|
|
||
| var anchorHip = true | ||
|
|
||
| var vrmJson: String? = null | ||
|
|
||
| override fun getPortIn(): Int { | ||
| return portIn | ||
| } | ||
|
|
||
| override fun setPortIn(portIn: Int) { | ||
| this.portIn = portIn | ||
| } | ||
|
|
||
| override fun getPortOut(): Int { | ||
| return portOut | ||
| } | ||
|
|
||
| override fun setPortOut(portOut: Int) { | ||
| this.portOut = portOut | ||
| } |
There was a problem hiding this comment.
Can't these getters and setters just be override properties?
https://kotlinlang.org/docs/inheritance.html#overriding-properties
| private var portIn: Int = 39540 | |
| private var portOut: Int = 39539 | |
| var anchorHip = true | |
| var vrmJson: String? = null | |
| override fun getPortIn(): Int { | |
| return portIn | |
| } | |
| override fun setPortIn(portIn: Int) { | |
| this.portIn = portIn | |
| } | |
| override fun getPortOut(): Int { | |
| return portOut | |
| } | |
| override fun setPortOut(portOut: Int) { | |
| this.portOut = portOut | |
| } | |
| override var portIn: Int = 39540 | |
| override var portOut: Int = 39539 | |
| var anchorHip = true | |
| var vrmJson: String? = null |
There was a problem hiding this comment.
Why does VMCConfig overrides all the same from OSCConfig... also just rewrite it all in kotlin without getters and setters.
|
boop |
|
@Louka3000 resolve the conversations and conflicts, what's the boop about? |
| private var portIn: Int = 39540 | ||
| private var portOut: Int = 39539 | ||
|
|
||
| var anchorHip = true | ||
|
|
||
| var vrmJson: String? = null | ||
|
|
||
| override fun getPortIn(): Int { | ||
| return portIn | ||
| } | ||
|
|
||
| override fun setPortIn(portIn: Int) { | ||
| this.portIn = portIn | ||
| } | ||
|
|
||
| override fun getPortOut(): Int { | ||
| return portOut | ||
| } | ||
|
|
||
| override fun setPortOut(portOut: Int) { | ||
| this.portOut = portOut | ||
| } |
There was a problem hiding this comment.
Why does VMCConfig overrides all the same from OSCConfig... also just rewrite it all in kotlin without getters and setters.
| @@ -7,10 +7,10 @@ public class OSCConfig { | |||
| private boolean enabled = false; | |||
|
|
|||
| // Port to receive OSC messages from | |||
| private int portIn; | |||
| private int portIn = 9002; | |||
There was a problem hiding this comment.
The class gets extended and the fields get used in children, make it protected or rewrite in kotlin and make public.
The boop is about Butter’s review not being taken care of |
related to #610