Firmware tool #880
Open
Firmware tool #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usefull when using Localized as you wont require to put a placeholder inside the button for it to be replaced by Localized anyway
The dropdown has been redone to use portals making the different unfocus states easier to handle and also allowing for the dropdown items to go over sections with overflow hidden. Also the getValues props has been removed as it is not needed and was a wrong usage of react-form-hooks
The TrashIcon component has been refactored to accept `size` as an optional prop instead of `width`. The `size` prop is now used to set the width and height of the SVG element in the component. This change ensures consistency and improves the flexibility of the TrashIcon component. The ClearDriftCompensationButton and ClearMountingButton components have also been updated to use the new `size` prop when referencing the TrashIcon component. This change ensures that the TrashIcon used in these components is displayed with the desired size. Additionally, the ArrowUpIcon component has been updated to accept `size` as an optional prop instead of required. This change provides flexibility when using the ArrowUpIcon component, as the size can now be specified or defaulted to 24. Finally, the LoaderIcon component has been updated to accept `size` as an optional prop instead of required. The `size` prop is now used to set the width of the images in the component. This change allows for more customizable size options for the LoaderIcon component.
This was
linked to
issues
Nov 5, 2023
ImUrX
added
Area: Application Protocol
ImUrX
requested review from
ButterscotchV,
Eirenliel,
Erimelowo and
ImUrX
as code owners
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not review this, it is A DRAFT, still
Requires SlimeVR/SolarXR-Protocol#125