Add support for left/right steamvr toggles #982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImUrX
added
Area: GUI
ImUrX
requested review from
ButterscotchV,
Eirenliel and
Erimelowo
as code owners
Erimelowo
approved these changes
Apr 8, 2024
ButterscotchV
approved these changes
Apr 9, 2024
|
it works but its lazily put together, settings is currently a mess. (when you enable one, the warning popups and turns both on, you can later disable the one you dont want tho) |
Hmm that's what I'd thought might be the case, well basically nobody should reasonably be using it anyways so meh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the original ones, it's too much work doing both of them in React, we need to refactor settings for it.
Also checks for feeder trackers so it doesn't replace them. (maybe could be removed on #920 merge)
Fixes #786
depends on SlimeVR/SolarXR-Protocol#138